diff --git a/.changeset/curly-boxes-return.md b/.changeset/curly-boxes-return.md new file mode 100644 index 000000000..c78ed43dd --- /dev/null +++ b/.changeset/curly-boxes-return.md @@ -0,0 +1,5 @@ +--- +'@primer/primitives': patch +--- + +Updates inactive button text colors to meet contrast against the inactive button background color. diff --git a/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-dark-colorblind-theme-1-linux.png b/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-dark-colorblind-theme-1-linux.png index 6e812b6fc..6236ae084 100644 Binary files a/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-dark-colorblind-theme-1-linux.png and b/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-dark-colorblind-theme-1-linux.png differ diff --git a/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-dark-high-contrast-theme-1-linux.png b/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-dark-high-contrast-theme-1-linux.png index 0210388ab..be6a96b4b 100644 Binary files a/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-dark-high-contrast-theme-1-linux.png and b/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-dark-high-contrast-theme-1-linux.png differ diff --git a/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-dark-theme-1-linux.png b/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-dark-theme-1-linux.png index 582dfad3c..b5b8fffc5 100644 Binary files a/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-dark-theme-1-linux.png and b/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-dark-theme-1-linux.png differ diff --git a/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-dark-tritanopia-theme-1-linux.png b/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-dark-tritanopia-theme-1-linux.png index 75262a8dd..f19db19cc 100644 Binary files a/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-dark-tritanopia-theme-1-linux.png and b/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-dark-tritanopia-theme-1-linux.png differ diff --git a/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-light-colorblind-theme-1-linux.png b/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-light-colorblind-theme-1-linux.png index 457ad00be..18a5965b9 100644 Binary files a/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-light-colorblind-theme-1-linux.png and b/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-light-colorblind-theme-1-linux.png differ diff --git a/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-light-high-contrast-theme-1-linux.png b/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-light-high-contrast-theme-1-linux.png index a2915ee85..e2cb0e310 100644 Binary files a/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-light-high-contrast-theme-1-linux.png and b/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-light-high-contrast-theme-1-linux.png differ diff --git a/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-light-theme-1-linux.png b/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-light-theme-1-linux.png index 78cd7e6bb..08f90740b 100644 Binary files a/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-light-theme-1-linux.png and b/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-light-theme-1-linux.png differ diff --git a/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-light-tritanopia-theme-1-linux.png b/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-light-tritanopia-theme-1-linux.png index 2b27ee85f..4a8c8de1f 100644 Binary files a/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-light-tritanopia-theme-1-linux.png and b/.playwright/snapshots/storybook.test.ts-snapshots/storybook-color-patterns--button-all-themes-light-tritanopia-theme-1-linux.png differ diff --git a/data/colors/vars/component_dark.ts b/data/colors/vars/component_dark.ts index ff908708c..f08f901f0 100644 --- a/data/colors/vars/component_dark.ts +++ b/data/colors/vars/component_dark.ts @@ -149,7 +149,7 @@ export default { inactive: { bg: get('scale.gray.7'), - text: get('fg.muted'), + text: get('scale.gray.3'), } }, underlinenav: { diff --git a/data/colors/vars/component_light.ts b/data/colors/vars/component_light.ts index 99df67b30..6c7bc45b1 100644 --- a/data/colors/vars/component_light.ts +++ b/data/colors/vars/component_light.ts @@ -150,7 +150,7 @@ export default { inactive: { bg: get('scale.gray.1'), - text: get('fg.muted'), + text: get('scale.gray.6'), } }, underlinenav: { diff --git a/src/tokens/functional/color/dark/patterns-dark.json5 b/src/tokens/functional/color/dark/patterns-dark.json5 index a22f94ec1..cf345d0fa 100644 --- a/src/tokens/functional/color/dark/patterns-dark.json5 +++ b/src/tokens/functional/color/dark/patterns-dark.json5 @@ -1534,7 +1534,7 @@ inactive: { fgColor: { rest: { - $value: '{fgColor.muted}', + $value: '{base.color.gray.3}', $type: 'color', $extensions: { 'org.primer.figma': { diff --git a/src/tokens/functional/color/light/patterns-light.json5 b/src/tokens/functional/color/light/patterns-light.json5 index b08063704..cfdcc1cd1 100644 --- a/src/tokens/functional/color/light/patterns-light.json5 +++ b/src/tokens/functional/color/light/patterns-light.json5 @@ -1530,7 +1530,7 @@ inactive: { fgColor: { rest: { - $value: '{fgColor.muted}', + $value: '{base.color.gray.6}', $type: 'color', $extensions: { 'org.primer.figma': {