Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add components to support skeleton loading states #4052

Merged
merged 43 commits into from
Jun 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
28e2c47
adds skeleton components and stories
mperrotti Dec 11, 2023
95c1080
supports use of skeletons in AvatarStack and AvatarPair
mperrotti Dec 11, 2023
0a01424
Merge branch 'main' of github.com:primer/react into mp/skeleton
mperrotti Dec 11, 2023
3911423
replaces ad-hoc skeleton loaders in DataTable and TreeView
mperrotti Dec 11, 2023
75ecf73
adds VRTs
mperrotti Dec 11, 2023
5926a0e
rm unused stuff from stories
mperrotti Dec 11, 2023
1375c92
adds component prop docs for Skeleton components
mperrotti Dec 11, 2023
f343eaf
adds changeset
mperrotti Dec 11, 2023
4853a32
Merge branch 'main' into mp/skeleton
mperrotti Dec 12, 2023
23bd514
Merge branch 'main' of github.com:primer/react into mp/skeleton
mperrotti Dec 12, 2023
ee2ad6b
Merge branch 'main' of github.com:primer/react into mp/skeleton
mperrotti Dec 14, 2023
e75c6e0
Merge branch 'mp/skeleton' of github.com:primer/react into mp/skeleton
mperrotti Dec 14, 2023
998625b
disable animations for VRTs and aXe tests
mperrotti Dec 14, 2023
56bbbdf
Merge branch 'main' into mp/skeleton
mperrotti Dec 18, 2023
57896b1
Merge branch 'main' into mp/skeleton
mperrotti Dec 18, 2023
04c6432
Merge branch 'main' into mp/skeleton
mperrotti Dec 19, 2023
432c8fd
Merge branch 'main' into mp/skeleton
mperrotti Dec 19, 2023
45eb614
Merge branch 'main' into mp/skeleton
mperrotti Dec 19, 2023
63c3975
Merge branch 'main' into mp/skeleton
mperrotti Dec 19, 2023
dd3d1f6
Merge branch 'main' into mp/skeleton
mperrotti Dec 19, 2023
b228a2d
Merge branch 'main' into mp/skeleton
mperrotti Dec 19, 2023
cb9afcd
fix typos in skeletonbone VRTs/AATs
mperrotti Dec 19, 2023
4fbf452
Merge branch 'main' of github.com:primer/react into mp/skeleton
mperrotti Dec 19, 2023
e0b90f1
Merge branch 'mp/skeleton' of github.com:primer/react into mp/skeleton
mperrotti Dec 19, 2023
107037f
test(vrt): update snapshots
mperrotti Dec 19, 2023
6d038ed
Merge branch 'main' into mp/skeleton
mperrotti Dec 21, 2023
c0676a7
adds skeleton loader example using React Suspense
mperrotti Feb 1, 2024
1daedbb
renames 'SkeletonBone' to 'SkeletonBox'
mperrotti Feb 1, 2024
3f1c8b0
Merge branch 'main' of github.com:primer/react into mp/skeleton
mperrotti Feb 8, 2024
2aa30d0
Merge branch 'main' of github.com:primer/react into mp/skeleton
mperrotti Jun 12, 2024
488909c
updates needed since this PR was opened so long ago
mperrotti Jun 12, 2024
776eb0c
Merge branch 'main' into mp/skeleton
mperrotti Jun 13, 2024
5d9a67f
try resetting package-lock to whats in main
mperrotti Jun 13, 2024
a3f1e66
appease the linter
mperrotti Jun 13, 2024
c5c45c5
moves BaseSkeletonBox styles to SkeletonBox, and co-locates skeleton …
mperrotti Jun 13, 2024
b1425a2
replace 'sx' prop with 'className' where possible
mperrotti Jun 13, 2024
63eedb7
rm sx usage, appease linter
mperrotti Jun 13, 2024
cd2b032
updates snaps, rms sx from story argtypes
mperrotti Jun 13, 2024
d598024
Merge branch 'main' into mp/skeleton
mperrotti Jun 17, 2024
c2c321b
Merge branch 'main' into mp/skeleton
mperrotti Jun 17, 2024
a33c95d
test(Skeleton): update id for SkeletonBox stories
joshblack Jun 18, 2024
a2d6094
chore: update snapshots
joshblack Jun 18, 2024
2f8d800
test(vrt): update snapshots
joshblack Jun 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/chilled-dolphins-eat.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@primer/react': minor
---

Adds components to support skeleton loading states, and uses those components to replace ad-hoc skeleton loading states in Primer React components.

<!-- Changed components: SkeletonAvatar, SkeletonBox, SkeletonText -->
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading