Skip to content

Conversation

@siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Apr 4, 2024

Changelog

  • In automatically provide localised Date for SSR in RelativeTime #4305, we render the render as a child. This however overwrites children if they were passed. Found this integration tests for dotcom
  • I talked to @keithamus and the ideal fix would be to update instances of RelativeTime, carefully remove children and then disallow children from the props
  • To unblock the release, we can make the backwards compatible change of rendering children if they were passed instead of our default
  • skipping changeset because this patches an unreleased PR

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; Patches an unreleased change

Testing & Reviewing

Merge checklist

@siddharthkp siddharthkp requested a review from a team as a code owner April 4, 2024 11:06
@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2024

⚠️ No Changeset found

Latest commit: 6761978

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89 KB (+0.04% 🔺)
packages/react/dist/browser.umd.js 89.26 KB (+0.01% 🔺)

@siddharthkp siddharthkp requested a review from joshblack April 4, 2024 12:20
@siddharthkp siddharthkp removed the request for review from joshblack April 4, 2024 13:46
@siddharthkp siddharthkp added this pull request to the merge queue Apr 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 4, 2024
@siddharthkp siddharthkp added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 0b54799 Apr 4, 2024
@siddharthkp siddharthkp deleted the fix-4305 branch April 4, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants