From 16112b1274c9fc4844998a83d57129fbc873c495 Mon Sep 17 00:00:00 2001
From: Mike Perrotti <mperrotti@github.com>
Date: Fri, 7 Jun 2024 08:28:15 -0400
Subject: [PATCH 1/2] prevents inactive danger actionmenu items from changing
 color on hover

---
 packages/react/src/ActionList/Visuals.tsx                  | 7 ++++---
 .../react/src/ActionMenu/ActionMenu.features.stories.tsx   | 6 +++++-
 .../src/__tests__/__snapshots__/Autocomplete.test.tsx.snap | 2 +-
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/packages/react/src/ActionList/Visuals.tsx b/packages/react/src/ActionList/Visuals.tsx
index 146515fc744..5ec5e6f61f3 100644
--- a/packages/react/src/ActionList/Visuals.tsx
+++ b/packages/react/src/ActionList/Visuals.tsx
@@ -38,9 +38,10 @@ export const LeadingVisual: React.FC<React.PropsWithChildren<VisualProps>> = ({s
         {
           color: getVariantStyles(variant, disabled, inactive).iconColor,
           svg: {fontSize: 0},
-          '[data-variant="danger"]:hover &, [data-variant="danger"]:active &': {
-            color: getVariantStyles(variant, disabled, inactive).hoverColor,
-          },
+          '[data-variant="danger"]:not([aria-disabled]):not([data-inactive]):hover &, [data-variant="danger"]:active &':
+            {
+              color: getVariantStyles(variant, disabled, inactive).hoverColor,
+            },
         },
         sx as SxProp,
       )}
diff --git a/packages/react/src/ActionMenu/ActionMenu.features.stories.tsx b/packages/react/src/ActionMenu/ActionMenu.features.stories.tsx
index 670e3b49cc8..ff7ea0c382c 100644
--- a/packages/react/src/ActionMenu/ActionMenu.features.stories.tsx
+++ b/packages/react/src/ActionMenu/ActionMenu.features.stories.tsx
@@ -158,7 +158,11 @@ export const InactiveItems = () => (
             <GearIcon />
           </ActionList.LeadingVisual>
         </ActionList.LinkItem>
-        <ActionList.Item onSelect={() => alert('Make a copy clicked')} inactiveText="Unavailable due to an outage">
+        <ActionList.Item
+          variant="danger"
+          onSelect={() => alert('Make a copy clicked')}
+          inactiveText="Unavailable due to an outage"
+        >
           Make a copy
           <ActionList.LeadingVisual>
             <CopyIcon />
diff --git a/packages/react/src/__tests__/__snapshots__/Autocomplete.test.tsx.snap b/packages/react/src/__tests__/__snapshots__/Autocomplete.test.tsx.snap
index b8b62001e1f..0a6cc2ab235 100644
--- a/packages/react/src/__tests__/__snapshots__/Autocomplete.test.tsx.snap
+++ b/packages/react/src/__tests__/__snapshots__/Autocomplete.test.tsx.snap
@@ -652,7 +652,7 @@ exports[`snapshots renders a menu that contains an item to add to the menu 1`] =
   font-size: 12px;
 }
 
-[data-variant="danger"]:hover .c4,
+[data-variant="danger"]:not([aria-disabled]):not([data-inactive]):hover .c4,
 [data-variant="danger"]:active .c9 {
   color: var(--fgColor-default,var(--color-fg-default,#1F2328));
 }

From 73017468a7a255e59822eb13f7894ca105ee4b0d Mon Sep 17 00:00:00 2001
From: Mike Perrotti <mperrotti@github.com>
Date: Fri, 7 Jun 2024 09:21:34 -0400
Subject: [PATCH 2/2] adds changeset

---
 .changeset/honest-olives-laugh.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 .changeset/honest-olives-laugh.md

diff --git a/.changeset/honest-olives-laugh.md b/.changeset/honest-olives-laugh.md
new file mode 100644
index 00000000000..2a27e35fa02
--- /dev/null
+++ b/.changeset/honest-olives-laugh.md
@@ -0,0 +1,5 @@
+---
+'@primer/react': patch
+---
+
+Prevents text color from changing on hover for "inactive" ActionMenu.Items of the "danger" variant. Before this change, the text color would change on hover. After this change, the text color remains the same on hover.