-
Notifications
You must be signed in to change notification settings - Fork 620
Clean up the feature flag for primer_react_segmented_control_tooltip
#6307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: df63579 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
primer_react_segmented_control_tooltip
primer_react_segmented_control_tooltip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the feature flag for primer_react_segmented_control_tooltip
and formally graduates the tooltip functionality for SegmentedControl.IconButton to general availability. The change makes tooltips the default behavior without requiring a feature flag.
- Remove the feature flag
primer_react_segmented_control_tooltip
from the codebase - Simplify the SegmentedControlIconButton component by removing conditional rendering logic
- Update tests to reflect the new default behavior
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
packages/react/src/SegmentedControl/SegmentedControlIconButton.tsx | Remove feature flag check and conditional rendering, keeping only the tooltip-enabled code path |
packages/react/src/SegmentedControl/SegmentedControl.test.tsx | Update test descriptions and remove feature flag wrapper from tests |
packages/react/src/FeatureFlags/DefaultFeatureFlags.ts | Remove the primer_react_segmented_control_tooltip feature flag definition |
.changeset/strong-mangos-rest.md | Add changelog entry documenting the removal of the feature flag |
da08487
to
df63579
Compare
Closes: https://github.com/github/primer/issues/4723
Changelog
Removed
Removes feature flag for
primer_react_segmented_control_tooltip
and formally GAs having a tooltip by default on SegmentedControl.IconButtonRollout strategy
Testing & Reviewing
Merge checklist