Skip to content

Clean up the feature flag for primer_react_segmented_control_tooltip #6307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented Jul 8, 2025

Closes: https://github.com/github/primer/issues/4723

Changelog

Removed

Removes feature flag for primer_react_segmented_control_tooltip and formally GAs having a tooltip by default on SegmentedControl.IconButton

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Jul 8, 2025

🦋 Changeset detected

Latest commit: df63579

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 8, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 8, 2025
Copy link
Contributor

github-actions bot commented Jul 8, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 91.92 KB (+0.02% 🔺)
packages/react/dist/browser.umd.js 92.08 KB (-0.17% 🔽)

@github-actions github-actions bot requested a deployment to storybook-preview-6307 July 8, 2025 19:27 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6307 July 8, 2025 19:36 Inactive
@khiga8 khiga8 changed the title [Hold] Clean up the feature flag for primer_react_segmented_control_tooltip Clean up the feature flag for primer_react_segmented_control_tooltip Jul 18, 2025
@khiga8 khiga8 marked this pull request as ready for review July 18, 2025 14:42
@Copilot Copilot AI review requested due to automatic review settings July 18, 2025 14:42
@khiga8 khiga8 requested a review from a team as a code owner July 18, 2025 14:42
@khiga8 khiga8 requested a review from TylerJDev July 18, 2025 14:42
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the feature flag for primer_react_segmented_control_tooltip and formally graduates the tooltip functionality for SegmentedControl.IconButton to general availability. The change makes tooltips the default behavior without requiring a feature flag.

  • Remove the feature flag primer_react_segmented_control_tooltip from the codebase
  • Simplify the SegmentedControlIconButton component by removing conditional rendering logic
  • Update tests to reflect the new default behavior

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/react/src/SegmentedControl/SegmentedControlIconButton.tsx Remove feature flag check and conditional rendering, keeping only the tooltip-enabled code path
packages/react/src/SegmentedControl/SegmentedControl.test.tsx Update test descriptions and remove feature flag wrapper from tests
packages/react/src/FeatureFlags/DefaultFeatureFlags.ts Remove the primer_react_segmented_control_tooltip feature flag definition
.changeset/strong-mangos-rest.md Add changelog entry documenting the removal of the feature flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants