fix(SelectPanel): prioritize message over loading status

[francinelucca]

Closes https://github.com/github/primer/issues/5402

Fixes bug where the selectpanel is empty from the beginning and the loading status is displayed instead of the empty message.

Changelog

Changed

• renders message if exists instead of loading status

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

🦋 Changeset detected

Latest commit: c935294

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Copilot]

Pull Request Overview

This PR fixes a bug in SelectPanel where the loading status was being displayed instead of the empty message when the panel starts empty. The change prioritizes showing messages over loading indicators by reordering the conditional logic.

• Reorders conditional checks in getBodyContent() to prioritize message display over loading status
• Ensures that when both a message and loading state exist, the message takes precedence

[github-actions]

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	91.96 KB (+0.07% 🔺)
packages/react/dist/browser.umd.js	92.21 KB (-0.03% 🔽)

[primer-integration]

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/391255

[primer-integration]

🟢 golden-jobs completed with status success.