-
Notifications
You must be signed in to change notification settings - Fork 646
Revert "v38: Move Banner to main export (#6720)" #6739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 0466819.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts the move of the Banner component from the experimental exports to the main public API. The Banner component is being moved back to @primer/react/experimental because it has existing usage in dotcom that needs to be updated before it can be removed from the experimental entrypoint.
Key Changes:
- Reverts Banner component from main exports back to experimental exports
- Updates all Banner import references throughout the codebase
- Modifies Storybook story titles to reflect experimental status
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/index.ts | Removes Banner and BannerProps exports from main package |
| packages/react/src/experimental/index.ts | Re-adds Banner and BannerProps exports to experimental package |
| packages/react/src/tests/snapshots/exports.test.ts.snap | Updates test snapshots to reflect new export structure |
| packages/react/src/Button/Button.examples.stories.tsx | Updates Banner import to use experimental path |
| packages/react/src/Banner/Banner.stories.tsx | Changes story title to experimental namespace |
| packages/react/src/Banner/Banner.figma.tsx | Updates Banner import to use experimental path |
| packages/react/src/Banner/Banner.features.stories.tsx | Changes story title to experimental namespace |
| packages/react/src/Banner/Banner.examples.stories.tsx | Changes story title to experimental namespace |
| packages/react/src/Banner/Banner.docs.json | Updates import path and story IDs to experimental |
| e2e/components/Banner.test.ts | Updates all story IDs to experimental namespace |
| .changeset/fast-countries-remain.md | Empty changeset file |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
llastflowers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
This reverts commit 0466819.
When going through the release, it seems like this change has usage in dotcom that needs to be updated before we can remove these components from the
@primer/react/experimentalentrypoint 👀