Skip to content

Conversation

@joshblack
Copy link
Member

This reverts commit 0466819.

When going through the release, it seems like this change has usage in dotcom that needs to be updated before we can remove these components from the @primer/react/experimental entrypoint 👀

Copilot AI review requested due to automatic review settings September 5, 2025 18:43
@joshblack joshblack requested a review from a team as a code owner September 5, 2025 18:43
@joshblack joshblack requested a review from pksjce September 5, 2025 18:43
@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2025

⚠️ No Changeset found

Latest commit: eecd244

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 5, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the move of the Banner component from the experimental exports to the main public API. The Banner component is being moved back to @primer/react/experimental because it has existing usage in dotcom that needs to be updated before it can be removed from the experimental entrypoint.

Key Changes:

  • Reverts Banner component from main exports back to experimental exports
  • Updates all Banner import references throughout the codebase
  • Modifies Storybook story titles to reflect experimental status

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/react/src/index.ts Removes Banner and BannerProps exports from main package
packages/react/src/experimental/index.ts Re-adds Banner and BannerProps exports to experimental package
packages/react/src/tests/snapshots/exports.test.ts.snap Updates test snapshots to reflect new export structure
packages/react/src/Button/Button.examples.stories.tsx Updates Banner import to use experimental path
packages/react/src/Banner/Banner.stories.tsx Changes story title to experimental namespace
packages/react/src/Banner/Banner.figma.tsx Updates Banner import to use experimental path
packages/react/src/Banner/Banner.features.stories.tsx Changes story title to experimental namespace
packages/react/src/Banner/Banner.examples.stories.tsx Changes story title to experimental namespace
packages/react/src/Banner/Banner.docs.json Updates import path and story IDs to experimental
e2e/components/Banner.test.ts Updates all story IDs to experimental namespace
.changeset/fast-countries-remain.md Empty changeset file

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 5, 2025
@joshblack joshblack enabled auto-merge September 5, 2025 18:46
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 87.33 KB (-0.86% 🔽)
packages/react/dist/browser.umd.js 87.39 KB (-0.84% 🔽)

Copy link
Contributor

@llastflowers llastflowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshblack joshblack added this pull request to the merge queue Sep 5, 2025
@joshblack joshblack added the skip changeset This change does not need a changelog label Sep 5, 2025
Merged via the queue into main with commit 66fa82a Sep 5, 2025
47 checks passed
@joshblack joshblack deleted the revert/promote-banner-componeont branch September 5, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants