From 0aab81deab371f28bc6cd799ef463377d856320f Mon Sep 17 00:00:00 2001 From: Pavithra Kodmad Date: Fri, 10 Oct 2025 22:36:14 +1100 Subject: [PATCH 1/4] It kinda fixes it --- .../src/ActionMenu/ActionMenu.module.css | 37 +++++++++++++++++++ packages/react/src/ActionMenu/ActionMenu.tsx | 8 +++- 2 files changed, 44 insertions(+), 1 deletion(-) diff --git a/packages/react/src/ActionMenu/ActionMenu.module.css b/packages/react/src/ActionMenu/ActionMenu.module.css index 15a2fbd9834..e1ed97c53dd 100644 --- a/packages/react/src/ActionMenu/ActionMenu.module.css +++ b/packages/react/src/ActionMenu/ActionMenu.module.css @@ -2,4 +2,41 @@ &:where([data-variant='fullscreen']) { padding-top: var(--base-size-36); } + + /* Overflow variants */ + &:where([data-overflow-auto]) { + overflow: auto; + } + + &:where([data-overflow-hidden]) { + overflow: hidden; + } + + &:where([data-overflow-scroll]) { + overflow: scroll; + } + + &:where([data-overflow-visible]) { + overflow: visible; + } + + /* Max-height size tokens (mirror Overlay sizes) */ + &:where([data-max-height-xsmall]) { + max-height: 192px; + } + &:where([data-max-height-small]) { + max-height: 256px; + } + &:where([data-max-height-medium]) { + max-height: 320px; + } + &:where([data-max-height-large]) { + max-height: 432px; + } + &:where([data-max-height-xlarge]) { + max-height: 600px; + } + &:where([data-max-height-fit-content]) { + max-height: fit-content; + } } diff --git a/packages/react/src/ActionMenu/ActionMenu.tsx b/packages/react/src/ActionMenu/ActionMenu.tsx index 23e0cf7e001..bb5fa0bc652 100644 --- a/packages/react/src/ActionMenu/ActionMenu.tsx +++ b/packages/react/src/ActionMenu/ActionMenu.tsx @@ -303,7 +303,13 @@ const Overlay: React.FC> = ({ onPositionChange={onPositionChange} variant={variant} > -
+
Date: Fri, 10 Oct 2025 22:40:33 +1100 Subject: [PATCH 2/4] Create serious-schools-hope.md --- .changeset/serious-schools-hope.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/serious-schools-hope.md diff --git a/.changeset/serious-schools-hope.md b/.changeset/serious-schools-hope.md new file mode 100644 index 00000000000..92aa8287447 --- /dev/null +++ b/.changeset/serious-schools-hope.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +Fix: ActionMenu with overflow doesn’t contain scrollbars within its rounded border From f28fad15944a4bd954cdb4e61c31182fae3ce02a Mon Sep 17 00:00:00 2001 From: Pavithra Kodmad Date: Mon, 13 Oct 2025 16:15:12 +1100 Subject: [PATCH 3/4] style(ActionMenu): add spacing between max-height variants --- packages/react/src/ActionMenu/ActionMenu.module.css | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/packages/react/src/ActionMenu/ActionMenu.module.css b/packages/react/src/ActionMenu/ActionMenu.module.css index e1ed97c53dd..4c9b063d239 100644 --- a/packages/react/src/ActionMenu/ActionMenu.module.css +++ b/packages/react/src/ActionMenu/ActionMenu.module.css @@ -24,18 +24,23 @@ &:where([data-max-height-xsmall]) { max-height: 192px; } + &:where([data-max-height-small]) { max-height: 256px; } + &:where([data-max-height-medium]) { max-height: 320px; } + &:where([data-max-height-large]) { max-height: 432px; } + &:where([data-max-height-xlarge]) { max-height: 600px; } + &:where([data-max-height-fit-content]) { max-height: fit-content; } From 4452cb738a80cbf73cc64fcd20e097fca1074a1d Mon Sep 17 00:00:00 2001 From: Pavithra Kodmad Date: Tue, 14 Oct 2025 21:53:25 +1100 Subject: [PATCH 4/4] Fix ActionMenu overflow scrollbars appearance --- .changeset/serious-schools-hope.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/serious-schools-hope.md b/.changeset/serious-schools-hope.md index 92aa8287447..5e92b762869 100644 --- a/.changeset/serious-schools-hope.md +++ b/.changeset/serious-schools-hope.md @@ -2,4 +2,4 @@ "@primer/react": patch --- -Fix: ActionMenu with overflow doesn’t contain scrollbars within its rounded border +Fix: ActionMenu with overflow contains scrollbars within its rounded border