Inline ops that read settings #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelff
force-pushed
the
fetch-settings-in-one-query
branch
from
5b62283 to
41338e7
Compare
|
Measures taken on 100 coldstart connections: Before patch: After patch: Average: 152.8317912 Inline queries makes connection run ~30% faster. |
Weakky
reviewed
Apr 19, 2023
src/conn/mod.rs
Outdated
| Some(value) | ||
| // set max_allowed_packet | ||
| let max_allowed_packet = if read_max_allowed_packet { | ||
| settings.as_ref().map(|s| s.1).unwrap() |
There was a problem hiding this comment.
Nitpick: you could get the result as a Row and then use row::get("column_name"). Might increase visibility, nothing blocking anyway.
|
Cool, did a pass to the test suite using the same configuration defined in |
miguelff
pushed a commit
that referenced
this pull request
Apr 20, 2023
Measures taken on 100 coldstart connections to a remote RDS mysql 5.7 in us-east-1, accessed from Spain. Units are ms. Before patch: Average: 222.01605959 Standard deviation: 20.28249939282523 After patch: Average: 152.8317912 Standard deviation: 22.382571070107467 Inlining queries make connections that require reading server settings run ~30% faster.
miguelff
added a commit
to prisma/prisma-engines
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating the patch first against the branch we use in prisma-engines.