[Shop] fix sessions for cloudrun #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Firebase requires to use "__session" as a cookie name. - Replace default session store by "memorystore" - Set cookie sameSite attribute to "strict"
in case where multiple instances would run, set up session affinity to preserve the session state
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Express JS session management did not work with Firebase/CloudRun due to Firebase constraints. it requires to name the session cookies "__session")
Express JS session management now uses memorystore module, to store session data in memory.
Enable session affinity on Cloud Run in case multiple instances are running so users get their cart content (it's only for demo purpose, in real-life session data should be managed using a third party database like Redis)
Related Issue
Affected services
Other: