Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release dev to main #157

Merged
merged 97 commits into from
Oct 13, 2023
Merged

Release dev to main #157

merged 97 commits into from
Oct 13, 2023

Conversation

Seburan
Copy link
Contributor

@Seburan Seburan commented Oct 5, 2023

Description

Release changes made between july and september to main and public site.

Related Issue

Affected services

  • Home
  • News
  • Shop
  • Travel
  • DSP
  • SSP
  • ALL

Other:

JackJey and others added 30 commits July 14, 2023 14:08
synchronize dev from main branch
approving merge to dev branch for review and testing
.env file for dev environment
Update topics service - add TOPICS_SERVER_HOST via param
Update topics-server repsponse headers; Update topics page;
[.env] restore correct OT for ssp and dsp
- Cloud Build configuration to build & depoy to Cloud Run in 1 command
- Setup multiple environment (.env.xxx) to trigger Cloud Build from
GitHub commit on dev/stage/main
CI/CD automation with Cloud Build
home html files need to be built to be deployed by ci/cd.
add docusaurus build operation in ci/cd
[CI/CD] build html files with Cloud Build
@Seburan Seburan marked this pull request as draft October 6, 2023 01:34
@Seburan Seburan added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request javascript Pull requests that update Javascript code labels Oct 6, 2023
maybellineboon and others added 17 commits October 7, 2023 14:50
Add Private Aggregation Reporting for News Site
add markdown entry for vast video protected audience
[home] add video ad use case doc
Fixed Demos index.md with Video Ads addition.
Fixed the category name for Video ads within intro.md file.
Removed extra ;'s in JS blocks.
Updated some relative links to permalinks for VAST Video API docs.
Fix codeql + move renderURL from SSP to DSP +
</a>
</li>
<li>
<a target="_blank" href="<%= new URL(`https://${SSP_HOST}:${EXTERNAL_PORT}/ads?advertiser=${SHOP_HOST}&id=1f45e`) %>">
<%= new URL(`https://${SSP_HOST}:${EXTERNAL_PORT}/ads?advertiser=${SHOP_HOST}&id=1f45e`) %>
<a target="_blank"

Check warning

Code scanning / CodeQL

Potentially unsafe external link Medium

External links without noopener/noreferrer are a potential security risk.
</ins>

<h2>inside iframe</h2>
<ul>
<li>
<a target="_blank" href="<%= new URL(`https://${SSP_HOST}:${EXTERNAL_PORT}/ad-tag.html`) %>">
<%= new URL(`https://${SSP_HOST}:${EXTERNAL_PORT}/ad-tag.html`) %>
<a target="_blank"

Check warning

Code scanning / CodeQL

Potentially unsafe external link Medium

External links without noopener/noreferrer are a potential security risk.
@Seburan Seburan marked this pull request as ready for review October 13, 2023 09:25
@Seburan Seburan merged commit 5acddf5 into main Oct 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants