-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy multi-seller video ad demo to prod #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setup Protected Audience multi-seller skeleton
in order to allow communications between services using FQDN hostnames within the docker bridge network
fixes multi-seller-auction demo to run both on docker & cloud run
allows communications between services based : .env -> with docker bridge network .env.dev -> with Cloud Run / Firebase hosting
Multi seller auction network
Handle CORS
fixing environment vars for Cloud dev deployment
kevinkiklee
changed the title
Deploy dev to prod
Deploy multi-seller video ad demo to prod
Feb 6, 2024
Seburan
reviewed
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO before releasing to prod :
- update release notes / changelog with v1.3.0
- create use case walkthrough documentation under https://github.com/privacysandbox/privacy-sandbox-demos/tree/main/services/home/docs/demos
- add attestation files (enrollment wip)
This reverts commit 8dccf10.
Add 1.3.0 changelog
documentation placeholder for Instream video ad in a Protected Audience multi-seller auction
for multi-seller auction
Update documentation for multi-seller auction & insteam video demo
Seburan
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for prod release conditioned to :
- update doc placeholder of (or link to) use case demo doc for instream video ad with paapi multi-seller auction
- add attestation files for dsp1,dsp2,ssp1,ssp2,ad-server
services/home/docs/demos/instream-video-ad-paapi-multi-seller-auction.md
Outdated
Show resolved
Hide resolved
[home] fix broken links in docs
- upgrade docusaurus to 3.1.1 - fix duplicated index for instream video doc
[home] upgrade doc platform and fix docusaurus build error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR deploys the multi-seller video ad demo on dev to prod
Affected services