Reintegrate the simple single-seller auction after unified refactor #494
+233
−248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With all existing use-cases migrated to use sequential auction setups, we are left with 2 auction executor scripts in the
ad-tech
service'ssrc/public/js/ssp
directory -- the newerrun-sequential-ad-auction.js
and the olderrun-ad-auction.js
. In addition to using sequential auction setups as the name suggests, the newerrun-sequential-ad-auction.js
is also capable to handling multiple ad slots and multiple ad types on the page. Increasing the flexibility from these features also increases the complexity of the script. In comparison, the existingrun-ad-auction.js
only executes the Protected Audience auction in a single-seller setup and can only handle a single ad slot for a display ad. This PR reintegrates the simplified single-seller Protected-Audience-only auction on thenews/index
page as the simplest demonstration for Protected Audience.Affected services
Changelog
Changes to
ad-tech
public/js/ssp/run-ad-auction.js
to.../run-simple-ad-auction.js
.public/js/ssp/ssp-tag.js
to.../ad-server-tag.js
.HOSTNAME
to JavaScript template variables.Changes to
news
index.ejs
file tomultiple-ad.ejs
.index.ejs
with a single ad unit for a fenced-frame display ad in a single-seller auction setup. Add a new view handler for the index page that is executed before the generic view handler. Specify a differentAD_SERVER_TAG_URL
for the index page than that used for the remaining pages. The index page usesrun-simple-ad-auction.js
, whereas the other pages use the more realisticssp-tag.js
which can handle multiple ad slots.aside
view component which lists the available demo pages on thenews
site.