Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove step-trace and trace features #1248

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

akoshelev
Copy link
Collaborator

Those were used to generate steps graph at runtime, but we've migrated to the new step engine that generates it at compile time, so we no longer need a script and this set of features

Those were used to generate steps graph at runtime, but we've migrated to the new step engine that generates it at compile time, so we no longer need a script and this set of features
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.72%. Comparing base (77ac0b0) to head (411c771).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
ipa-core/src/telemetry/step_stats.rs 0.00% 4 Missing ⚠️
ipa-core/src/test_fixture/world.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1248      +/-   ##
==========================================
- Coverage   92.73%   92.72%   -0.01%     
==========================================
  Files         200      200              
  Lines       31486    31470      -16     
==========================================
- Hits        29197    29182      -15     
+ Misses       2289     2288       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akoshelev akoshelev merged commit 53ef056 into private-attribution:main Sep 5, 2024
12 of 13 checks passed
@akoshelev akoshelev deleted the rem-trace branch September 5, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants