Move decrypt/encrypt functions to their own modules #1294
Conversation
We will add secret sharing, so crypto module will grow in size. It makes sense to keep things in their own modules now. It also does a bit of a refactoring to prepare to encrypt something that is not `IpaPrivateData`, but no new functionality is added by this change.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1294 +/- ##
==========================================
+ Coverage 93.40% 93.41% +0.01%
==========================================
Files 206 208 +2
Lines 33754 33798 +44
==========================================
+ Hits 31528 31574 +46
+ Misses 2226 2224 -2 ☔ View full report in Codecov by Sentry. |
ipa-core/src/cli/crypto/mod.rs
Outdated
| /// Keys that are used in crypto tests | ||
| #[derive(Clone)] | ||
| pub(super) struct TestKeys { | ||
| inner: [(IpaPublicKey, IpaPrivateKey); 3], |
There was a problem hiding this comment.
wouldn't keys be more descriptive than inner? maybe TestKeys.keys is too repetitive...
There was a problem hiding this comment.
I am probably abusing inner too much, I agree that keys is better if we add anything else inside after. I'll stick with key_pairs
| let input_file = sample_data::write_csv(sample_data::test_ipa_data().take(10)).unwrap(); | ||
|
|
||
| let output_dir = tempdir().unwrap(); | ||
| let network_data = r#" |
There was a problem hiding this comment.
should this use the format! macro used below? I didn't know that existed when I wrote this
There was a problem hiding this comment.
we could use it, but I thought for this test we don't need to inject the correct keys, so the benefit of using format! is not clear
We will add secret sharing, so crypto module will grow in size. It makes sense to keep things in their own modules now.
It also does a bit of a refactoring to prepare to encrypt something that is not
IpaPrivateData, but no new functionality is added by this change.