Reduce number of iterations for breakdown reveal test #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are having some flakiness with this test: https://github.com/private-attribution/ipa/actions/runs/11018449181/job/30598750956?pr=1307 and I attribute it to having too many iterations (by default it is set to 32). Even running it locally takes a long time and it is not possible to have reliable detection for large routines.
akoshelev
commented
Sep 25, 2024
| @@ -187,7 +187,7 @@ mod tests { | |||
| let stream = | |||
| BodyStream::from_bytes_stream(stream::once(future::ready(Ok(Bytes::from(data))))); | |||
|
|
|||
| stream.try_collect::<Vec<_>>().await.unwrap() | |||
| stream.try_collect::<Vec<_>>().await.unwrap(); | |||
There was a problem hiding this comment.
I had to make this change to keep run function definition the same for shuttle and tokio executors
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1314 +/- ##
=======================================
Coverage 93.45% 93.45%
=======================================
Files 207 207
Lines 33451 33455 +4
=======================================
+ Hits 31260 31267 +7
+ Misses 2191 2188 -3 ☔ View full report in Codecov by Sentry. |
benjaminsavage
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are having some flakiness with this test: https://github.com/private-attribution/ipa/actions/runs/11018449181/job/30598750956?pr=1307 and I attribute it to having too many iterations (by default it is set to 32). Even running it locally takes a long time and it is not possible to have reliable detection for large routines.
This attempts to fix #1312