Skip to content

Commit

Permalink
feat: Adapt skore to be compliant on python >=3.9, <3.13
Browse files Browse the repository at this point in the history
  • Loading branch information
thomass-dev committed Oct 10, 2024
1 parent 1b7562f commit c8d8aed
Show file tree
Hide file tree
Showing 14 changed files with 47 additions and 446 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/skore.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
strategy:
fail-fast: true
matrix:
python-version: ['3.11', '3.12']
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
Expand All @@ -62,8 +62,7 @@ jobs:
python -m build
# Install
python -m pip install dist/*.whl --no-dependencies
python -m pip install -r requirements.txt -r requirements-test.txt
python -m pip install dist/*.whl
# Test
python -m pytest src/ tests/
Expand Down
16 changes: 2 additions & 14 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,17 +1,5 @@
SKORE_ROOT ?= ".datamander"

pip-compile:
python -m piptools compile --output-file=skore/requirements.txt skore/pyproject.toml
python -m piptools compile --extra=test --output-file=skore/requirements-test.txt skore/pyproject.toml
python -m piptools compile --extra=tools --output-file=skore/requirements-tools.txt skore/pyproject.toml

install-skore:
python -m pip install \
-e skore/ \
-r skore/requirements.txt \
-r skore/requirements-test.txt \
-r skore/requirements-tools.txt

python -m pip install -e skore/
pre-commit install

build-skore-ui:
Expand All @@ -29,7 +17,7 @@ build-skore-ui:
mv skore-ui/dist/ skore/src/skore/ui/static

serve-skore-ui:
SKORE_ROOT=$(SKORE_ROOT) python -m uvicorn \
python -m uvicorn \
--factory skore.ui.app:create_app \
--reload --reload-dir skore/src \
--host 0.0.0.0 \
Expand Down
11 changes: 6 additions & 5 deletions skore/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@ dynamic = [
"readme",
"version"
]
requires-python = ">=3.11"
maintainers = [
{name = "skore developers", email="skore@signal.probabl.ai"},
]
requires-python = ">=3.9, <3.14"
maintainers = [{name = "skore developers", email="skore@signal.probabl.ai"}]
dependencies = [
"diskcache",
"fastapi",
Expand All @@ -30,8 +28,11 @@ classifiers=[
"Operating System :: Unix",
"Operating System :: MacOS",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12"
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
]

[project.urls]
Expand Down
202 changes: 0 additions & 202 deletions skore/requirements-test.txt

This file was deleted.

101 changes: 0 additions & 101 deletions skore/requirements-tools.txt

This file was deleted.

Loading

0 comments on commit c8d8aed

Please sign in to comment.