-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the way object types are tested in DisplayType
to remove excessive requirements
#113
Comments
DisplayType
to remove excessive requirements
This is an early optimization. |
This issue's wording is obsolete after #303, but the issue of testing an object's type without having to import all the libraries for which we offer auto-detection is still current. We have been experimenting with a string-based approach, which is simple, if dirty: def isinstance_(o: object, type_: str):
return type_ in [t.__module__ + '.' + t.__name__ for t in o.__class__.__mro__]
o = alt.Chart()
assert isinstance_(o, "altair.vegalite.v5.schema.core.TopLevelSpec") |
Does this affect dependencies needed to pip install skore? |
Yes. skore doesn't need anymore pandas etc. If an user want to use the |
These requirements are heavy and only presents to test object type.
They must not be present in prod requirements if they are not really used.
For instance, change the way object types are tested:
The text was updated successfully, but these errors were encountered: