Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other visualization librairies #331

Closed
MarieS-WiMLDS opened this issue Sep 11, 2024 · 4 comments
Closed

Support other visualization librairies #331

MarieS-WiMLDS opened this issue Sep 11, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@MarieS-WiMLDS
Copy link
Contributor

Current state

Only Altair plots can be stored in Skore.

Improved state

Other (if not all if possible, according to technical design?) librairies are supported by Skore.

Blocker

  • define what lib should be added. I suggest: plotly, matplotlib and seaborn.
@MarieS-WiMLDS MarieS-WiMLDS added the enhancement New feature or request label Sep 11, 2024
@sylvaincom
Copy link
Contributor

sylvaincom commented Sep 11, 2024

Indeed, I am not familiar with Altair (like Marie, I am much more familiar with plotly, matplotlib, seaborn) and I got the following error when using Altair:

MaxRowsError: The number of rows in your dataset is greater than the maximum allowed (5000).

and I believe 5000 rows is not much?

However, I found this in the documentation Large Datasets - Altair that explains how to let Altair plot more than 5000 rows, they have the following claim about their intended restriction:

This is not because Altair cannot handle larger datasets, but it is because it is important for the user to think carefully about how large datasets are handled.

But I think a junior DS does not need to trouble himself with that.

@rouk1
Copy link
Contributor

rouk1 commented Sep 16, 2024

As soon as #303 is merged you'll be able to store any kind of raster/vector in the report. Hence matplotlib will be supported.
Screenshot 2024-09-16 at 10 41 42

Could you provide a list of which library should be supported and some snippets of how to use them ?

@tuscland
Copy link
Member

This is not because Altair cannot handle larger datasets, but it is because it is important for the user to think carefully about how large datasets are handled.

But I think a junior DS does not need to trouble himself with that.

This is a valid point, but then it asks the question: what makes other libraries able to plot large number of rows?

I can identify reasons why someone/a library would like to limit the number of rows:

  • raster render time (once when the image is generated)
  • vector render time (every time the image is rendered in the browser)

How do other (vector plotting) libraries deal with this issue? @sylvaincom it would be very useful to research a bit on the solution others provide.

@thomass-dev do you think it would be easy to support plotly as well? It is very popular.

@tuscland
Copy link
Member

Fixed by #373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants