Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt skore to be compliant on python >=3.9 #390

Closed
thomass-dev opened this issue Sep 24, 2024 · 5 comments · Fixed by #471
Closed

Adapt skore to be compliant on python >=3.9 #390

thomass-dev opened this issue Sep 24, 2024 · 5 comments · Fixed by #471
Assignees
Labels
chore Internal enhancement work to be done

Comments

@thomass-dev
Copy link
Collaborator

thomass-dev commented Sep 24, 2024

Actually, skore only enforce compatibility with python >=3.12, but scikit-learn allows python >= 3.9.
Related issue #388 .

@augustebaum
Copy link
Contributor

Does this issue include adding a test pipeline for all supported versions?

@tuscland
Copy link
Member

I think this falls in the larger project of testing skore on multiple environments.

cc @jerome-probabl

@thomass-dev
Copy link
Collaborator Author

Does this issue include adding a test pipeline for all supported versions?

There is already an issue on this need #388 .

I think this falls in the larger project of testing skore on multiple environments.

cc @jerome-probabl

Not sure, its only a question of python versions, not multiple environments.

@tuscland
Copy link
Member

The Python version is a part of the environment.

@thomass-dev
Copy link
Collaborator Author

My point is that github-actions tools already seem to exist to test a package on several python versions.

@tuscland tuscland added the chore Internal enhancement work to be done label Oct 1, 2024
@thomass-dev thomass-dev linked a pull request Oct 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Internal enhancement work to be done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants