Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Store to Project #325

Merged
merged 74 commits into from
Sep 17, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
74 commits
Select commit Hold shift + click to select a range
fb43de6
Squashed commit of the following:
rouk1 Sep 10, 2024
bfd11a8
various
augustebaum Sep 10, 2024
5f1c834
only display cards that are in the layout
rouk1 Sep 10, 2024
c012af3
fix card size rendering
rouk1 Sep 10, 2024
57a4c98
reactivate report builder's placeholder
rouk1 Sep 10, 2024
83ead30
use local storage to temporary store the layout
rouk1 Sep 10, 2024
74007d0
Squashed commit of the following:
thomass-dev Sep 11, 2024
e58d4b9
renable sharing feature
rouk1 Sep 11, 2024
e6eb35d
hide used keys from the left pane
rouk1 Sep 11, 2024
fe8744e
mob done
augustebaum Sep 11, 2024
a8489cc
tidy web app file layout
rouk1 Sep 11, 2024
7dd1f7a
various refactorings
augustebaum Sep 11, 2024
ebf2a1c
web app: fix 404 on all routes + test endpoints
rouk1 Sep 11, 2024
a107bee
matplot lib figure support
rouk1 Sep 12, 2024
038fa3e
fix `test_version`
augustebaum Sep 12, 2024
2a00f8b
fix errors in tests
augustebaum Sep 12, 2024
9a4c3f3
fix `test_get_report`
augustebaum Sep 12, 2024
10b38f7
remove `test_list_stores`
augustebaum Sep 12, 2024
fc9c50d
fix `test_launch`
augustebaum Sep 12, 2024
8b3d91e
remove `test_share`
augustebaum Sep 12, 2024
a682f6f
remove `test_get_store_by_uri`
augustebaum Sep 12, 2024
8f64a7c
remove `test_put_layout`
augustebaum Sep 12, 2024
a4a9523
replace `Store` with `Project` in `TestApiApp`
augustebaum Sep 12, 2024
35c6dfb
remove `test_default_store.py`
augustebaum Sep 12, 2024
929a18b
fix `test_api_get_items`
augustebaum Sep 12, 2024
a4541b0
create dict like storages
rouk1 Sep 12, 2024
197aee2
remove registry
augustebaum Sep 12, 2024
254f3a8
adapt tests in `test_store.py` to fit in `test_project.py`
augustebaum Sep 12, 2024
0975d7d
use dict like persisitence classes
rouk1 Sep 12, 2024
4c0653a
clean up tests
rouk1 Sep 12, 2024
57f4d30
please ruff
rouk1 Sep 12, 2024
39a91c2
mob done
augustebaum Sep 12, 2024
8cededf
[ci skip] Draft item using OOP
thomass-dev Sep 12, 2024
703f29f
report's layout now persist in the backend
rouk1 Sep 12, 2024
78acc87
[ci skip] Add cached property to some items
thomass-dev Sep 12, 2024
8e88ff3
Move item_repository to dedicated branch 'draft-item-using-oop'
thomass-dev Sep 12, 2024
002c237
split `test_project` into one test per example
augustebaum Sep 12, 2024
336d7ee
fix bug in "share" endpoint
augustebaum Sep 12, 2024
1b3a60d
Draft item classes using OOP (#333)
thomass-dev Sep 13, 2024
72eebf0
mob done
augustebaum Sep 13, 2024
21bcd8e
fix report API tests
rouk1 Sep 13, 2024
a9b15d7
move cli commands to their own module
augustebaum Sep 13, 2024
e2f73d3
[ci skip] Fix parts of item unittests
thomass-dev Sep 13, 2024
3568a2b
fix item tests
augustebaum Sep 13, 2024
0cf9686
add tests for LayoutRepository
augustebaum Sep 13, 2024
02c8cfc
fix ruff errors
augustebaum Sep 13, 2024
3676ab8
format
augustebaum Sep 13, 2024
39d584a
replace __dict__ + vars with introspection to retrieve initialization…
thomass-dev Sep 13, 2024
03c15a8
fix frontend, for frontend API serialization, and use 2 Repository ev…
rouk1 Sep 13, 2024
5524331
add docstrings
rouk1 Sep 13, 2024
a6eff35
rename stuffs to please my coworkers
rouk1 Sep 13, 2024
9903702
Transform the test of cli.launch from integration to unit
thomass-dev Sep 16, 2024
fbe009b
split medias and infos keys
rouk1 Sep 16, 2024
96ff4b0
fix CI
rouk1 Sep 16, 2024
d0d16f1
Use rich to display nicer tracebacks
augustebaum Sep 16, 2024
ce481c6
Rename `create_project` function to `__create`
augustebaum Sep 16, 2024
cfde6a1
Fix error handling in `project.load`
augustebaum Sep 16, 2024
b9d8bc8
Reorder `__launch`
augustebaum Sep 16, 2024
3eed972
replace `os.mkdir` with `Path.mkdir`
augustebaum Sep 16, 2024
97cbcf7
Separate creation of nested project directories from creation of project
augustebaum Sep 16, 2024
7a318b6
Use rich.traceback only if skore is used through CLI
augustebaum Sep 16, 2024
7b33835
Merge branch 'main' into 303-project-api
augustebaum Sep 16, 2024
32be187
Update example notebook
augustebaum Sep 16, 2024
452a045
Update Readme
augustebaum Sep 16, 2024
43b3f44
Fix notebook HTML
augustebaum Sep 16, 2024
e384297
Move global logger to its own file
augustebaum Sep 16, 2024
1baa2a9
Revert "Move global logger to its own file"
augustebaum Sep 16, 2024
9e77191
Fix HTML in example notebook (ipynb)
augustebaum Sep 16, 2024
ef694a0
Add CLI-specific logger
augustebaum Sep 16, 2024
190b5e0
Update `skrub_demo` test notebook
augustebaum Sep 16, 2024
48cd4d9
Address PR feedback
augustebaum Sep 16, 2024
937e343
Remove "project.skore" argument from readme
augustebaum Sep 17, 2024
4777703
Lazy imports of third-part libraries in Items
thomass-dev Sep 17, 2024
aece316
Add unittest for SklearnBaseEstimatorItem
thomass-dev Sep 17, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/ShareApp.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<script setup lang="ts">
import Simplebar from "simplebar-vue";

import DataStoreCanvas from "@/components/DataStoreCanvas.vue";
import ReportCanvas from "@/components/ReportCanvas.vue";
</script>

<template>
Expand All @@ -10,7 +10,7 @@ import DataStoreCanvas from "@/components/DataStoreCanvas.vue";
<h1>Report</h1>
</div>
<Simplebar class="canvas-wrapper">
<DataStoreCanvas :showCardButtons="false" />
<ReportCanvas :showCardButtons="false" />
</Simplebar>
</div>
</template>
Expand Down
138 changes: 0 additions & 138 deletions frontend/src/components/DataStoreCanvas.vue

This file was deleted.

58 changes: 0 additions & 58 deletions frontend/src/components/FileTree.vue

This file was deleted.

110 changes: 0 additions & 110 deletions frontend/src/components/FileTreeItem.vue

This file was deleted.

4 changes: 3 additions & 1 deletion frontend/src/components/ImageWidget.vue
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
<script setup lang="tsx">
import { computed } from "vue";

import { type SupportedImageMimeType } from "@/models";

interface ImageWidgetProps {
base64Src: string;
mimeType: "image/svg+xml" | "image/png" | "image/jpeg" | "image/webp";
mimeType: SupportedImageMimeType;
alt?: string;
}

Expand Down
Loading
Loading