Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions modification resulting in incompliant desktop file #220

Closed
ctr49 opened this issue Sep 15, 2022 · 3 comments · Fixed by #222
Closed

Actions modification resulting in incompliant desktop file #220

ctr49 opened this issue Sep 15, 2022 · 3 comments · Fixed by #222
Labels
bug Something isn't working

Comments

@ctr49
Copy link

ctr49 commented Sep 15, 2022

I could observe the following behavior with a Nextcloud AppImage and could not identify the problem to be related to the AppImage itself so I think go-appimage/appimaged is causing the issue:

Original desktop file has:

[Desktop Entry]
Categories=Utility;X-SuSE-SyncUtility;
Type=Application
Exec=nextcloud %u
Name=Nextcloud Desktop
Comment=Nextcloud desktop synchronization client
GenericName=Folder Sync
Icon=Nextcloud
Keywords=Nextcloud;syncing;file;sharing;
X-GNOME-Autostart-Delay=3
MimeType=application/vnd.nextcloud;x-scheme-handler/nc;
Actions=Quit;
[...]

However, the modified Actions line in the go-appimage-created desktop file reads:

[Desktop Entry]
Categories=Utility;X-SuSE-SyncUtility;
Type=Application
Exec=<path>/appimaged.AppImage wrap "<path>/Nextcloud-3.6.0-x86_64.AppImage" %u
Name=Nextcloud Desktop
Comment=<path>/Nextcloud-3.6.0-x86_64.AppImage
GenericName=Folder Sync
Icon=<path>/.cache/thumbnails/normal/5956fdd80355d96f01333cd9dc6e4b6f.png
Keywords=Nextcloud;syncing;file;sharing;
X-GNOME-Autostart-Delay=3
MimeType=application/vnd.nextcloud;x-scheme-handler/nc;
Actions=Trash;OpenPortableHome;CreatePortableHome;Extract;Show;Firejail;FirejailNoNetwork;FirejailPrivate;FirejailOverlayTmpfs;
[...]

lacking a Quit; action. As result, desktop-file-validate complains

appimagekit_5956fdd80355d96f01333cd9dc6e4b6f.desktop: error: action group "Desktop Action Quit" exists, but there is no matching action "Quit"

and there is an error when starting the application.

Tested with appimaged-718 (from continuous Build) and Nextcloud 3.6.0 appimage

@probonopd
Copy link
Owner

error: action group "Desktop Action Quit" exists, but there is no matching action "Quit"

These tests are done by https://gitlab.freedesktop.org/xdg/desktop-file-utils.

If you think that the error is by mistake, please open an issue there. Thanks!

@ctr49
Copy link
Author

ctr49 commented Sep 15, 2022

I'm not saying that the the tests are wrong, but that there is an issue with go-appimage rewriting of the Actions. Quit is indeed missing in the desktop file while it is present in the application.

@probonopd probonopd added the bug Something isn't working label Sep 16, 2022
@probonopd
Copy link
Owner

Ok, thanks for the clarification. Then it is a bug here. Would you be able to send a fix as a pull request?

@CalebQ42 CalebQ42 mentioned this issue Sep 19, 2022
probonopd pushed a commit that referenced this issue Sep 19, 2022
* Fix #220

* Fix desktop file in memory

* Fixed #220
Implemented fix mention in #110
Fixed issues caused by squashfs v0.6+ doing things more correctly
Changes build script so zig is not permenently installed and is cleaned

* Linked wrapped command's out and in to stdout and stdin.
Fixes #217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants