Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep pack-specific logic outside of the SDK #12

Open
eddie-knight opened this issue Apr 27, 2022 · 2 comments
Open

Keep pack-specific logic outside of the SDK #12

eddie-knight opened this issue Apr 27, 2022 · 2 comments
Assignees

Comments

@eddie-knight
Copy link
Member

eddie-knight commented Apr 27, 2022

This needs discussion from contributors!

I'd propose that we remove pack-specific logic, such as the Kubernetes code currently found in this repo

Reasons:

  • decreases clarity when looking at service packs, requiring contributors to bounce over to the SDK to learn about test-specific code
  • decreases clarity of what the SDK is intended for
  • If shared code exists between a vanilla pack & a provider-specific pack, it could be argued that the logical place for the common code to exist is within the vanilla pack
@lluuiissoo
Copy link
Contributor

100% agree with this. SDK is a bit bloated at the moment.

SDK responsibility should be: To enable the creation of a new Service Pack, regardless of technology / business logic.
Functions:

  • Wrapper around remote plugin implementation so that new SP can hook into core runner
  • Provide interface for consistent logs
  • Provide interface for consistent config settings

@lluuiissoo
Copy link
Contributor

Any K8s and Azure specific logic/helpers should be removed from SDK into their own repos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants