Add custom assert() (PROF_ASSERT())
#1929
Conversation
Add custom macro to assert statement and log error prior to closing application, it allows us to handle `assert()`'s with a grace and track issues much better. Dependencies are updated in each file, "trace.h" is placed correctly near imports of similar nature. In 3 cases return statement were added alongside assert(FALSE) since compiler don't recognize 'abort()' in case of statement failure. In 1 case 2 imports of `<assert.h>` were replaced by 1 include of `trace.h` Resolves profanity-im#1895
|
Personally I fail to see the reason for it. |
The reason is on plain site: to make debugging easier. If someone has assert problem, he can provide profanity.log containing a line that shows where the problem has happened. Otherwise we need coredump, which not all the users can provide. |
|
That's exactly what I mean. For me it is default that under Linux we check things using gdb, get backtrace, receive a coredump from users. |
|
Not a big fan of this. And since noone else reviewed yet I'll close. |
See commit message.
Valgrind not needed in this case.
How to test the functionality
Resolve #1895