This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 163
fix: better config package to enhance test and restructuring #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: repo clone requires authentication Closes #198 * feat: add ability to set git protocol * Format code with gofmt This commit fixes the style issues introduced in 73ee693 according to the output from gofmt. Details: https://deepsource.io/gh/profclems/glab/transform/1a6879e9-070f-4a9f-a42c-ae4469dfc95d/ * fix: bug risks Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Best reviewed: commit by commit
Optimal code review plan (1 warning)
|
This commit fixes the style issues introduced in 1c0e597 according to the output from gofmt. Details: https://deepsource.io/gh/profclems/glab/transform/ce823f01-c76a-4927-9730-868dfe3c5012/
profclems
force-pushed
the
fix-better-config
branch
from
September 20, 2020 12:50
2f65321
to
fb011e3
Compare
This commit fixes the style issues introduced in fb011e3 according to the output from gofmt. Details: https://deepsource.io/gh/profclems/glab/transform/c6f8a52f-9c41-4b6f-a15a-9d77e43ff6b8/
Codecov Report
@@ Coverage Diff @@
## trunk #223 +/- ##
==========================================
+ Coverage 24.56% 26.46% +1.89%
==========================================
Files 76 83 +7
Lines 3985 4206 +221
==========================================
+ Hits 979 1113 +134
- Misses 2928 2990 +62
- Partials 78 103 +25
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glabs
's config read format (Environmental variables -> Local Config -> Global Config)Related Issue
#170
Motivation and Context
This PR seeks to resolve #170 while making it easier to work on #157
How Has This Been Tested?
This has been manually tested by building and running the binary and I have added tests to cover my changes.
Types of changes
Checklist:
TODO (Available for discussion)