Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

ft(pipeline): Add variables flag for pipeline run #352

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

zemzale
Copy link
Collaborator

@zemzale zemzale commented Dec 4, 2020

Description
This adds flag for running pipelines with custom variables passed to it.
They all default to env_var, for simplicity.

Related Issue

#319

Motivation and Context

This allows to run pipelines from command line with custom variables.
How Has This Been Tested?

Screenshots (if appropriate):
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zemzale
Copy link
Collaborator Author

zemzale commented Dec 4, 2020

@profclems I wrote up this MR so we can add this feature. Look over it please comment if there are some problems you see.
I intend to add some tests for this but I don't have the time for it right now, but would love some feedback so I can know that this is going the right way.

Copy link
Owner

@profclems profclems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with the implementation. Looks clean 🎉

commands/pipeline/run/pipeline_run.go Outdated Show resolved Hide resolved
@profclems profclems added the enhancement New feature or request label Dec 4, 2020
@profclems profclems linked an issue Dec 4, 2020 that may be closed by this pull request
@profclems
Copy link
Owner

@profclems I wrote up this MR so we can add this feature. Look over it please comment if there are some problems you see.
I intend to add some tests for this but I don't have the time for it right now, but would love some feedback so I can know that this is going the right way.

I actually like the implementation. This looks good. You can add the tests in a separate PR when you're ready

This adds flag for running pipelines with custom variables passed to it.
They all default to `env_var`.
@zemzale
Copy link
Collaborator Author

zemzale commented Dec 8, 2020

Yeah looks like I might add tests later on. I might not have the time in the next days, and never had done testing for CLIs like this so it's a bit to wrap my head around. If everything is okay then you are free to merge this

@profclems profclems merged commit 60db7b3 into profclems:trunk Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass variables when running a pipeline
2 participants