Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

Allow comma-separated labels for issue update #477

Merged
merged 1 commit into from
Dec 31, 2020

Conversation

profclems
Copy link
Owner

@profclems profclems commented Dec 31, 2020

Description
Use StringSliceP instead of StringArrayP to support both comma-separated values
and multiple usages.
https://pkg.go.dev/github.com/spf13/pflag@v1.0.5#StringArray
https://pkg.go.dev/github.com/spf13/pflag@v1.0.5#StringSlice

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

@profclems profclems added cmd: issue Related to issues management enhancement New feature or request labels Dec 31, 2020
@codecov
Copy link

codecov bot commented Dec 31, 2020

Codecov Report

Merging #477 (e614cdc) into trunk (bf5611e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk     #477   +/-   ##
=======================================
  Coverage   51.45%   51.45%           
=======================================
  Files          83       83           
  Lines        5455     5455           
=======================================
  Hits         2807     2807           
  Misses       2319     2319           
  Partials      329      329           
Impacted Files Coverage Δ
commands/issue/update/issue_update.go 64.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf5611e...e614cdc. Read the comment docs.

@profclems profclems force-pushed the feat-comma-separated-label-issue-update branch from b4380ea to e614cdc Compare December 31, 2020 22:34
@profclems profclems merged commit e2087e9 into trunk Dec 31, 2020
@profclems profclems deleted the feat-comma-separated-label-issue-update branch December 31, 2020 22:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cmd: issue Related to issues management enhancement New feature or request size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant