This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
respect GITLAB_HOST when resolving remotes #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When GITLAB_HOST or GITLAB_URI has been set, we resolve only local remotes that match the set hostname. With this in place, a heterogeneous mix of hosts in a local remote file will not cause GITLAB_HOST to be ignored. An error is returned if the hostname specified in GITLAB_HOST is not present in the local remotes.
profclems
force-pushed
the
fix-gitlab-host-env
branch
from
7c95f76
to
b438495
Compare
Codecov Report
@@ Coverage Diff @@
## trunk #500 +/- ##
==========================================
- Coverage 55.90% 55.87% -0.03%
==========================================
Files 83 83
Lines 5552 5562 +10
==========================================
+ Hits 3104 3108 +4
- Misses 2120 2125 +5
- Partials 328 329 +1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When GITLAB_HOST or GITLAB_URI has been set, we resolve only local remotes that match the set hostname.
With this in place, a heterogeneous mix of hosts in a local remote file will not cause GITLAB_HOST to be ignored.
An error is returned if the hostname specified in GITLAB_HOST is not present in the local remotes.
Resolves #499