This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Add more EXAMPLES for mr subcommands #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## trunk #538 +/- ##
==========================================
+ Coverage 60.66% 60.88% +0.21%
==========================================
Files 86 86
Lines 5880 5913 +33
==========================================
+ Hits 3567 3600 +33
Misses 1979 1979
Partials 334 334
Continue to review full report at Codecov.
|
profclems
suggested changes
Jan 8, 2021
commands/mr/close/mr_close.go
Outdated
Comment on lines
22
to
27
| Example: heredoc.Doc(` | ||
| $ glab mr close 1 | ||
| $ glab mr close branch | ||
| $ glab mr close username:branch | ||
| $ glab mr close branch -R another/repo |
There was a problem hiding this comment.
Also without supplying any argument, it finds the mr for the current branch
Suggested change
| Example: heredoc.Doc(` | |
| $ glab mr close 1 | |
| $ glab mr close branch | |
| $ glab mr close username:branch | |
| $ glab mr close branch -R another/repo | |
| Example: heredoc.Doc(` | |
| $ glab mr close # Closes mr for current branch | |
| $ glab mr close 1 | |
| $ glab mr close branch | |
| $ glab mr close username:branch | |
| $ glab mr close branch -R another/repo |
profclems
suggested changes
Jan 8, 2021
commands/mr/delete/mr_delete.go
Outdated
Comment on lines
23
to
25
| $ glab delete 123 | ||
| $ glab del 123 | ||
| $ glab delete branch |
There was a problem hiding this comment.
You missed the mr command here:
Suggested change
| $ glab delete 123 | |
| $ glab del 123 | |
| $ glab delete branch | |
| $ glab mr delete | |
| #=> deletes mr for current branch | |
| $ glab mr delete 123 | |
| $ glab mr del 123 | |
| $ glab mr delete branch |
profclems
reviewed
Jan 8, 2021
Comment on lines
+25
to
+26
| $ glab mr issues 46 | ||
| $ glab mr issues branch |
There was a problem hiding this comment.
Suggested change
| $ glab mr issues 46 | |
| $ glab mr issues branch | |
| $ glab mr issues 46 | |
| $ glab mr issues branch | |
| $ glab mr issues |
|
@maxice8 For all the |
|
Updated, thanks for noticing the mistakes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add EXAMPLES section for almost all subcommands
How Has This Been Tested?
bin/glab <subcommand> --helpTypes of changes