Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

refactor: move iostreams to own separate package #593

Merged
merged 9 commits into from
Jan 29, 2021
Merged

Conversation

profclems
Copy link
Owner

  • Move iostreams to own separate package
  • Fix references to iostream package
  • Add StartSpinner and StopSpinner methods

- Move iostreams to own separate package
- Fix references to iostream package
- Add StartSpinner and StopSpinner methods
@profclems profclems added the cleanup Code removal, deprecation, refactorings, etc. label Jan 29, 2021
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #593 (42930fd) into trunk (a086fdd) will increase coverage by 6.07%.
The diff coverage is 73.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #593      +/-   ##
==========================================
+ Coverage   54.64%   60.71%   +6.07%     
==========================================
  Files         103       90      -13     
  Lines        6980     6315     -665     
==========================================
+ Hits         3814     3834      +20     
+ Misses       2804     2120     -684     
+ Partials      362      361       -1     
Impacted Files Coverage Δ
commands/alias/list/alias_list.go 80.00% <ø> (ø)
commands/api/api.go 76.17% <ø> (ø)
commands/api/http.go 77.55% <ø> (ø)
commands/ci/trace/trace.go 73.23% <ø> (ø)
commands/ci/view/view.go 47.22% <ø> (ø)
commands/cmdutils/cmdutils.go 73.68% <ø> (ø)
commands/cmdutils/factory.go 0.00% <ø> (ø)
commands/cmdutils/remote_resolver.go 54.54% <ø> (ø)
commands/completion/completion.go 100.00% <ø> (ø)
commands/config/config.go 37.93% <0.00%> (ø)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a086fdd...42930fd. Read the comment docs.

@profclems profclems merged commit 6657174 into trunk Jan 29, 2021
@profclems profclems deleted the refactor-iostreams branch January 29, 2021 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cleanup Code removal, deprecation, refactorings, etc. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant