Skip to content

Conversation

@arturaz
Copy link
Collaborator

@arturaz arturaz commented Feb 2, 2025

See #962

arturaz added a commit to arturaz/packages that referenced this pull request Feb 5, 2025
@arturaz
Copy link
Collaborator Author

arturaz commented Feb 7, 2025

@yisraelU are you OK with merging this?

@arturaz
Copy link
Collaborator Author

arturaz commented Feb 11, 2025

Given that it has been 2 weeks since I raised this and there doesn't seem to be a response on your side @yisraelU, I am merging this :)

@arturaz arturaz merged commit 27dccff into profunktor:series/1.x Feb 11, 2025
2 checks passed
@arturaz arturaz deleted the fix/change-streaming-api branch February 11, 2025 07:20
@yisraelU
Copy link
Collaborator

Definitely not 2 weeks , but I understand your frustrations.
I still don't think this should be merged without a review from someone .
Especially a change such as this one.
I have not had much time over the past month.
Feel free to ask someone else for a review.

@arturaz
Copy link
Collaborator Author

arturaz commented Feb 11, 2025

Any suggestions on who else could review this? I don't know who the active maintainers are other than you.

Maybe @MamdouhAhmed could review it?

@arturaz
Copy link
Collaborator Author

arturaz commented Feb 11, 2025

Also, I don't think that the change is large. It just makes types more concrete, removing Stream.eval which turned F[_] to S[_], without touching the logic. I don't see how this can break anything (except for binary compatibility, of course).

In addition the whole streams module is said to be experimental, therefore it can be changed at-will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants