From 5929905fd26684eeb301bfbe7745be2830466e65 Mon Sep 17 00:00:00 2001 From: Justin Wood Date: Mon, 23 Oct 2023 22:43:09 -0700 Subject: [PATCH] Fixing this by ignoring shell harden (#29934) Co-authored-by: Karsten Sperling <113487422+ksperling-apple@users.noreply.github.com> Co-authored-by: Restyled.io --- .restyled.yaml | 1 + scripts/tagging/tag_new_release.sh | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.restyled.yaml b/.restyled.yaml index 06180a098228e9..aeedbacd16240c 100644 --- a/.restyled.yaml +++ b/.restyled.yaml @@ -76,6 +76,7 @@ exclude: - "examples/platform/nxp/k32w/k32w0/scripts/demo_generated_certs/**/*" - "integrations/cloudbuild/*.yaml" # uglier long command line content - "scripts/run_codegen_targets.sh" # shellharden breaks for loops over command outputs + - "scripts/tagging/tag_new_release.sh" # shellharden breaks parameter passing - "src/darwin/Framework/CHIP/zap-generated/*" # already clang-formatted by our zap tooling - "zzz_generated/**/*" # already clang-formatted by our zap tooling - "src/controller/java/generated/java/**/*" # not formatted: generated files diff --git a/scripts/tagging/tag_new_release.sh b/scripts/tagging/tag_new_release.sh index 1fca130cf8f385..0a1f3302808791 100755 --- a/scripts/tagging/tag_new_release.sh +++ b/scripts/tagging/tag_new_release.sh @@ -55,4 +55,4 @@ echo "New release: $NEW_RELEASE_TAG" echo "Additional arguments: $ADDITIONAL_ARGS" echo executing: gh release create "$NEW_RELEASE_TAG" --notes-start-tag "$CURRENT_RELEASE" "$@" "$ADDITIONAL_ARGS" -gh release create "$NEW_RELEASE_TAG" "--notes-start-tag" "$CURRENT_RELEASE" "$@" "$ADDITIONAL_ARGS" +gh release create $NEW_RELEASE_TAG "--notes-start-tag" $CURRENT_RELEASE $@ $ADDITIONAL_ARGS