From 7faa5b568d41b8d5962de6a9e242b3858d43b1b4 Mon Sep 17 00:00:00 2001 From: Vivien Nicolas Date: Mon, 30 Jan 2023 09:31:10 +0100 Subject: [PATCH] [cluster] Move ColorControl cluster to a dedicated file --- .github/workflows/tests.yaml | 2 +- scripts/rules.matterlint | 1 + src/app/zap-templates/zcl/data-model/all.xml | 2 +- .../data-model/chip/color-control-cluster.xml | 459 ++++++++++++++++++ .../data-model/draft/types/color-control.xml | 28 ++ .../zcl/data-model/silabs/ha.xml | 253 ---------- .../zcl/data-model/silabs/types-silabs.xml | 38 -- .../zcl/data-model/silabs/zll.xml | 145 ------ .../zcl/zcl-with-test-extensions.json | 3 +- src/app/zap-templates/zcl/zcl.json | 3 +- 10 files changed, 494 insertions(+), 440 deletions(-) create mode 100644 src/app/zap-templates/zcl/data-model/chip/color-control-cluster.xml create mode 100644 src/app/zap-templates/zcl/data-model/draft/types/color-control.xml delete mode 100644 src/app/zap-templates/zcl/data-model/silabs/zll.xml diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index a0370261e34ccb..8665962679de20 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -125,6 +125,7 @@ jobs: src/app/zap-templates/zcl/data-model/chip/chip-types.xml \ src/app/zap-templates/zcl/data-model/chip/channel-cluster.xml \ src/app/zap-templates/zcl/data-model/chip/clusters-extensions.xml \ + src/app/zap-templates/zcl/data-model/chip/color-control-cluster.xml \ src/app/zap-templates/zcl/data-model/chip/content-launch-cluster.xml \ src/app/zap-templates/zcl/data-model/chip/descriptor-cluster.xml \ src/app/zap-templates/zcl/data-model/chip/diagnostic-logs-cluster.xml \ @@ -182,7 +183,6 @@ jobs: src/app/zap-templates/zcl/data-model/silabs/lo-devices.xml \ src/app/zap-templates/zcl/data-model/silabs/types-silabs.xml \ src/app/zap-templates/zcl/data-model/silabs/zll-devices.xml \ - src/app/zap-templates/zcl/data-model/silabs/zll.xml \ " - name: Build Apps timeout-minutes: 60 diff --git a/scripts/rules.matterlint b/scripts/rules.matterlint index bf2b540d23cf8b..74d9cbcbb1e6ad 100644 --- a/scripts/rules.matterlint +++ b/scripts/rules.matterlint @@ -17,6 +17,7 @@ load "../src/app/zap-templates/zcl/data-model/chip/channel-cluster.xml"; load "../src/app/zap-templates/zcl/data-model/chip/chip-ota.xml"; load "../src/app/zap-templates/zcl/data-model/chip/chip-types.xml"; load "../src/app/zap-templates/zcl/data-model/chip/clusters-extensions.xml"; +load "../src/app/zap-templates/zcl/data-model/chip/color-control-cluster.xml"; load "../src/app/zap-templates/zcl/data-model/chip/content-launch-cluster.xml"; load "../src/app/zap-templates/zcl/data-model/chip/descriptor-cluster.xml"; load "../src/app/zap-templates/zcl/data-model/chip/diagnostic-logs-cluster.xml"; diff --git a/src/app/zap-templates/zcl/data-model/all.xml b/src/app/zap-templates/zcl/data-model/all.xml index 12093a14df4b68..7d1687fc2565f7 100644 --- a/src/app/zap-templates/zcl/data-model/all.xml +++ b/src/app/zap-templates/zcl/data-model/all.xml @@ -15,6 +15,7 @@ + @@ -72,5 +73,4 @@ - diff --git a/src/app/zap-templates/zcl/data-model/chip/color-control-cluster.xml b/src/app/zap-templates/zcl/data-model/chip/color-control-cluster.xml new file mode 100644 index 00000000000000..af32bca3ebea24 --- /dev/null +++ b/src/app/zap-templates/zcl/data-model/chip/color-control-cluster.xml @@ -0,0 +1,459 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + Color Control + Lighting + Attributes and commands for controlling the color properties of a color-capable light. + 0x0300 + COLOR_CONTROL_CLUSTER + + true + true + + + + CurrentHue + + CurrentSaturation + + RemainingTime + + CurrentX + + CurrentY + + DriftCompensation + + CompensationText + + ColorTemperatureMireds + + ColorMode + + Options + + NumberOfPrimaries + + Primary1X + + Primary1Y + + Primary1Intensity + + Primary2X + + Primary2Y + + Primary2Intensity + + Primary3X + + Primary3Y + + Primary3Intensity + + Primary4X + + Primary4Y + + Primary4Intensity + + Primary5X + + Primary5Y + + Primary5Intensity + + Primary6X + + Primary6Y + + Primary6Intensity + + + WhitePointX + + + + + + WhitePointY + + + + + + ColorPointRX + + + + + + ColorPointRY + + + + + + ColorPointRIntensity + + + + + + ColorPointGX + + + + + + ColorPointGY + + + + + + ColorPointGIntensity + + + + + + ColorPointBX + + + + + + ColorPointBY + + + + + + ColorPointBIntensity + + + + + CoupleColorTempToLevelMinMireds + + StartUpColorTemperatureMireds + + + + + + + Move to specified hue. + + + + + + + + + + + Move hue up or down at specified rate. + + + + + + + + + + Step hue up or down by specified size at specified rate. + + + + + + + + + + + Move to specified saturation. + + + + + + + + + + Move saturation up or down at specified rate. + + + + + + + + + + Step saturation up or down by specified size at specified rate. + + + + + + + + + + + Move to hue and saturation. + + + + + + + + + + + Move to specified color. + + + + + + + + + + + Moves the color. + + + + + + + + + + Steps the lighting to a specific color. + + + + + + + + + + + Move to a specific color temperature. + + + + + + + + + + EnhancedCurrentHue + EnhancedColorMode + ColorLoopActive + ColorLoopDirection + ColorLoopTime + ColorLoopStartEnhancedHue + ColorLoopStoredEnhancedHue + ColorCapabilities + ColorTempPhysicalMinMireds + ColorTempPhysicalMaxMireds + + + + Command description for EnhancedMoveToHue + + + + + + + + + + + Command description for EnhancedMoveHue + + + + + + + + + + Command description for EnhancedStepHue + + + + + + + + + + + Command description for EnhancedMoveToHueAndSaturation + + + + + + + + + + + Command description for ColorLoopSet + + + + + + + + + + + + + Command description for StopMoveStep + + + + + + + + Command description for MoveColorTemperature + + + + + + + + + + + + Command description for StepColorTemperature + + + + + + + + + + + diff --git a/src/app/zap-templates/zcl/data-model/draft/types/color-control.xml b/src/app/zap-templates/zcl/data-model/draft/types/color-control.xml new file mode 100644 index 00000000000000..5f42386d635c64 --- /dev/null +++ b/src/app/zap-templates/zcl/data-model/draft/types/color-control.xml @@ -0,0 +1,28 @@ + + + + + + + + + + + + + + diff --git a/src/app/zap-templates/zcl/data-model/silabs/ha.xml b/src/app/zap-templates/zcl/data-model/silabs/ha.xml index f078db7c9cfe96..96e38ca40b90a5 100644 --- a/src/app/zap-templates/zcl/data-model/silabs/ha.xml +++ b/src/app/zap-templates/zcl/data-model/silabs/ha.xml @@ -110,259 +110,6 @@ limitations under the License. - - Color Control - Lighting - Attributes and commands for controlling the color properties of a color-capable light. - 0x0300 - COLOR_CONTROL_CLUSTER - true - true - - CurrentHue - - CurrentSaturation - - RemainingTime - - CurrentX - - CurrentY - - DriftCompensation - - CompensationText - - ColorTemperatureMireds - - ColorMode - - Options - - NumberOfPrimaries - - Primary1X - - Primary1Y - - Primary1Intensity - - Primary2X - - Primary2Y - - Primary2Intensity - - Primary3X - - Primary3Y - - Primary3Intensity - - Primary4X - - Primary4Y - - Primary4Intensity - - Primary5X - - Primary5Y - - Primary5Intensity - - Primary6X - - Primary6Y - - Primary6Intensity - - - WhitePointX - - - - - - WhitePointY - - - - - - ColorPointRX - - - - - - ColorPointRY - - - - - - ColorPointRIntensity - - - - - - ColorPointGX - - - - - - ColorPointGY - - - - - - ColorPointGIntensity - - - - - - ColorPointBX - - - - - - ColorPointBY - - - - - - ColorPointBIntensity - - - - - CoupleColorTempToLevelMinMireds - - StartUpColorTemperatureMireds - - - - - - Move to specified hue. - - - - - - - - - - Move hue up or down at specified rate. - - - - - - - - - Step hue up or down by specified size at specified rate. - - - - - - - - - - Move to specified saturation. - - - - - - - - - Move saturation up or down at specified rate. - - - - - - - - - Step saturation up or down by specified size at specified rate. - - - - - - - - - - Move to hue and saturation. - - - - - - - - - - Move to specified color. - - - - - - - - - - Moves the color. - - - - - - - - - Steps the lighting to a specific color. - - - - - - - - - - Move to a specific color temperature. - - - - - - - - - - - - - - - Ballast Configuration Lighting diff --git a/src/app/zap-templates/zcl/data-model/silabs/types-silabs.xml b/src/app/zap-templates/zcl/data-model/silabs/types-silabs.xml index 571516eac006f8..0594d6a8f3e13d 100644 --- a/src/app/zap-templates/zcl/data-model/silabs/types-silabs.xml +++ b/src/app/zap-templates/zcl/data-model/silabs/types-silabs.xml @@ -159,44 +159,6 @@ limitations under the License. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/src/app/zap-templates/zcl/data-model/silabs/zll.xml b/src/app/zap-templates/zcl/data-model/silabs/zll.xml deleted file mode 100644 index 3457a99f900089..00000000000000 --- a/src/app/zap-templates/zcl/data-model/silabs/zll.xml +++ /dev/null @@ -1,145 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - EnhancedCurrentHue - EnhancedColorMode - ColorLoopActive - ColorLoopDirection - ColorLoopTime - ColorLoopStartEnhancedHue - ColorLoopStoredEnhancedHue - ColorCapabilities - ColorTempPhysicalMinMireds - ColorTempPhysicalMaxMireds - - - Command description for EnhancedMoveToHue - - - - - - - - - - Command description for EnhancedMoveHue - - - - - - - - - Command description for EnhancedStepHue - - - - - - - - - - Command description for EnhancedMoveToHueAndSaturation - - - - - - - - - - Command description for ColorLoopSet - - - - - - - - - - - - Command description for StopMoveStep - - - - - - - Command description for MoveColorTemperature - - - - - - - - - - - Command description for StepColorTemperature - - - - - - - - - - - diff --git a/src/app/zap-templates/zcl/zcl-with-test-extensions.json b/src/app/zap-templates/zcl/zcl-with-test-extensions.json index f82bcaecbfb3c5..39ff80947915fa 100644 --- a/src/app/zap-templates/zcl/zcl-with-test-extensions.json +++ b/src/app/zap-templates/zcl/zcl-with-test-extensions.json @@ -30,6 +30,7 @@ "channel-cluster.xml", "client-monitoring-cluster.xml", "clusters-extensions.xml", + "color-control-cluster.xml", "content-launch-cluster.xml", "descriptor-cluster.xml", "diagnostic-logs-cluster.xml", @@ -86,7 +87,7 @@ "ha.xml", "lo-devices.xml", "zll-devices.xml", - "zll.xml" + "types/color-control.xml" ], "manufacturersXml": "../../../../src/app/zap-templates/zcl/data-model/manufacturers.xml", "options": { diff --git a/src/app/zap-templates/zcl/zcl.json b/src/app/zap-templates/zcl/zcl.json index 11c0a1e837fda4..32a5a0bdc6784b 100644 --- a/src/app/zap-templates/zcl/zcl.json +++ b/src/app/zap-templates/zcl/zcl.json @@ -29,6 +29,7 @@ "channel-cluster.xml", "client-monitoring-cluster.xml", "clusters-extensions.xml", + "color-control-cluster.xml", "content-launch-cluster.xml", "descriptor-cluster.xml", "diagnostic-logs-cluster.xml", @@ -84,7 +85,7 @@ "ha.xml", "lo-devices.xml", "zll-devices.xml", - "zll.xml" + "types/color-control.xml" ], "manufacturersXml": "../../../../src/app/zap-templates/zcl/data-model/manufacturers.xml", "options": {