Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add release workflow #27

Merged
merged 12 commits into from
Feb 2, 2024

Conversation

ashnamehrotra
Copy link
Contributor

Adds release workflow. Closes #25.

Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>

- name: Create and push tag
run: |
git tag -a "${{ github.event.inputs.release_version }}" -m "${{ github.event.inputs.release_version }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need multiple tags. example: v1.2.0, v1.2, v1

Copy link
Member

@sozercan sozercan Jan 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we are creating a tag for something that's not latest (say v1.1.1), we don't want to update v1. this can be a follow up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure I understand. If we tag v1.1.1, would v1 be updated instead of creating a new tag?

Copy link
Member

@sozercan sozercan Jan 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examples:
release v1.2.0 -> new tags for v1.2.0, v1.2 and update tag for v1
release v1.1.1 (after v1.2.0 is out) -> update tags for v1.1, v1.1.1 (not v1 since that tracks v1.2.0 now)

let me know if i can clarify further

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made changes to push multiple tags based on input version. Looking into how to add a check if the release is after the next version is already out (v1.1.1 after v1.2.0 is out)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to add a check to compare minor versions when we release v1.1.1 after v1.2.0, and use latest ("https://github.com/ashnamehrotra/copa-action/releases/latest") to get v1.2.0 to compare. Im not sure if this will work because after this release latest would incorrectly point to v1.1.1?

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashnamehrotra ashnamehrotra merged commit 3761a62 into project-copacetic:main Feb 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create a release action
2 participants