-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add release workflow #27
feat: add release workflow #27
Conversation
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
.github/workflows/release.yaml
Outdated
|
||
- name: Create and push tag | ||
run: | | ||
git tag -a "${{ github.event.inputs.release_version }}" -m "${{ github.event.inputs.release_version }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need multiple tags. example: v1.2.0, v1.2, v1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we are creating a tag for something that's not latest (say v1.1.1), we don't want to update v1. this can be a follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure I understand. If we tag v1.1.1, would v1 be updated instead of creating a new tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
examples:
release v1.2.0 -> new tags for v1.2.0, v1.2 and update tag for v1
release v1.1.1 (after v1.2.0 is out) -> update tags for v1.1, v1.1.1 (not v1 since that tracks v1.2.0 now)
let me know if i can clarify further
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made changes to push multiple tags based on input version. Looking into how to add a check if the release is after the next version is already out (v1.1.1 after v1.2.0 is out)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to add a check to compare minor versions when we release v1.1.1 after v1.2.0, and use latest ("https://github.com/ashnamehrotra/copa-action/releases/latest") to get v1.2.0 to compare. Im not sure if this will work because after this release latest would incorrectly point to v1.1.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds release workflow. Closes #25.