Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetRef() in support package should remove 'vendor' path #224

Open
yxuco opened this issue Oct 8, 2020 · 2 comments
Open

GetRef() in support package should remove 'vendor' path #224

yxuco opened this issue Oct 8, 2020 · 2 comments
Assignees
@lixingwang @mellistibco

Comments

@yxuco
Copy link
Contributor

yxuco commented Oct 8, 2020

Current behavior (how does the issue manifest):
When working with older third-party packages that uses /vendor packages, GetRef() returns ref with path including '.../vendor/'

Expected behavior:
To make it work, GetRef() should return only the ref name, excluding the prefix up to '/vendor/'.

Minimal steps to reproduce the problem (not required if feature enhancement):

Please tell us about your environment (Operating system, docker version, browser & web ui version, etc):
OSX

Flogo version (CLI & contrib/lib. If unknown, leave empty or state unknown): 0.X.X
1.1.0

Additional information you deem important (e.g. issue happens only occasionally):
yxuco added a commit to yxuco/core that referenced this issue Oct 8, 2020
@yxuco
Resulve issue project-flogo#224 GetRef() in support package should re…
cf81f70 
…move 'vendor' path
@yxuco yxuco mentioned this issue Oct 8, 2020
Closed
@lixingwang
Copy link
Contributor

@yxuco GetRef most focusing on getting Flogo contribution ref. Are you saying that you put flogo contributions under the vendor?

@yxuco
Copy link
Contributor Author

yxuco commented Oct 8, 2020

Yes, I am compiling Flogo flow as a third-party app (i.e., Hyperledger Fabric v1.4 chaincode), which does not support go module, and so flogo packages are included under vendor folder, and so GetRef() would return the vendor folder path, causing runtime errors.

yxuco added a commit to yxuco/core that referenced this issue Dec 3, 2020
@yxuco
Resulve issue project-flogo#224 GetRef() in support package should re…
41e5656 
…move 'vendor' path

allows trigger developer to pass request parameters to handler w/o going through output mapper
yxuco added a commit to yxuco/core that referenced this issue Dec 10, 2020
@yxuco
resubmit pull request to resolve issue project-flogo#224
15c5d86
@yxuco yxuco mentioned this issue Dec 10, 2020
Merged
lixingwang pushed a commit that referenced this issue Dec 10, 2020
@yxuco
merge change for issue #224 (#245)
82972d8 
* Resulve issue #224 GetRef() in support package should remove 'vendor' path

* Resulve issue #224 GetRef() in support package should remove 'vendor' path
allows trigger developer to pass request parameters to handler w/o going through output mapper

* resubmit pull request to resolve issue #224
yxuco added a commit to yxuco/core that referenced this issue Jan 4, 2021
@yxuco
Resulve issue project-flogo#224 GetRef() in support package should re…
4f85a3b 
…move 'vendor' path

allows trigger developer to pass request parameters to handler w/o going through output mapper

Resulve issue project-flogo#224 GetRef() in support package should remove 'vendor' path

resubmit pull request to resolve issue project-flogo#224

Fix project-flogo#244 Trigger handler should provide option to pass request data to flow without explicit output mapping

update per comments on issue project-flogo#246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lixingwang lixingwang

@mellistibco mellistibco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lixingwang @yxuco @mellistibco