Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display <odd> #1456

Closed
marlo-longley opened this issue Dec 8, 2023 · 3 comments · Fixed by #1498
Closed

Display <odd> #1456

marlo-longley opened this issue Dec 8, 2023 · 3 comments · Fixed by #1498
Assignees
@gwiedeman

Comments

@marlo-longley
Copy link
Contributor

This is a widely used field.

This ticket is broken out of #898
@gwiedeman gwiedeman self-assigned this Dec 8, 2023
@gwiedeman gwiedeman mentioned this issue Dec 8, 2023
Merged
@gwiedeman gwiedeman moved this from Ready to In Progress in Arclight Community Sprint 3 - 2023 Dec 11, 2023
@gwiedeman gwiedeman moved this from In Progress to Done in Arclight Community Sprint 3 - 2023 Dec 11, 2023
@marlo-longley marlo-longley moved this from Done to In Review in Arclight Community Sprint 3 - 2023 Dec 15, 2023
@marlo-longley
Copy link
Contributor Author

marlo-longley commented Dec 15, 2023 •
edited
Loading

In searching the codebase I am not finding any <odd> in our fixture data. I think this needs further confirmation that it is being displayed even though I see it was added in #1466.

@gwiedeman
Copy link
Contributor

There is an <odd> here:

arclight/spec/fixtures/ead/nlm/alphaomegaalpha.xml

Line 77 in 9142012

<odd id="aspace_3be3b2c4bb6ad119fb3027aa9f75fb91">

But I didn't add tests for these, which could be useful.

@marlo-longley
Copy link
Contributor Author

Thank you!! Oops.

@marlo-longley marlo-longley mentioned this issue Dec 15, 2023
Merged
@seanaery seanaery mentioned this issue Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gwiedeman gwiedeman

Labels
None yet
Projects
Arclight Community Sprint 3 - 2023
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Display <odd> at component and collection levels projectblacklight/arclight
2 participants
@marlo-longley @gwiedeman