From d548f69f06fff0cde08185419c87dc5e3103427b Mon Sep 17 00:00:00 2001 From: Saman Mahdanian Date: Fri, 15 Mar 2024 00:47:36 +0330 Subject: [PATCH 1/3] set SpawnUpstreamSpan to true for generation new span Signed-off-by: Saman Mahdanian --- internal/envoy/v3/tracing.go | 1 + 1 file changed, 1 insertion(+) diff --git a/internal/envoy/v3/tracing.go b/internal/envoy/v3/tracing.go index 37eaed2d5f5..f66ca8b3ba8 100644 --- a/internal/envoy/v3/tracing.go +++ b/internal/envoy/v3/tracing.go @@ -55,6 +55,7 @@ func TracingConfig(tracing *EnvoyTracingConfig) *envoy_filter_network_http_conne }), }, }, + SpawnUpstreamSpan: wrapperspb.Bool(true), } } From 5eeb997f9cc68e06010856e8a5b25810a97c4311 Mon Sep 17 00:00:00 2001 From: Saman Mahdanian Date: Tue, 26 Mar 2024 12:14:00 +0330 Subject: [PATCH 2/3] Added change-log file Signed-off-by: Saman Mahdanian --- changelogs/unreleased/6271-SamMHD-minor.md | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 changelogs/unreleased/6271-SamMHD-minor.md diff --git a/changelogs/unreleased/6271-SamMHD-minor.md b/changelogs/unreleased/6271-SamMHD-minor.md new file mode 100644 index 00000000000..43cb5cc26f4 --- /dev/null +++ b/changelogs/unreleased/6271-SamMHD-minor.md @@ -0,0 +1,4 @@ +## Spawn Upstream Span is now enabled in tracing + +As described in [Envoy documentations](https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/network/http_connection_manager/v3/http_connection_manager.proto#extensions-filters-network-http-connection-manager-v3-httpconnectionmanager-tracing), ```spawn_upstream_span``` should be true when envoy is working as an independent proxy and from now on contour tracing spans will show up as a parent span to upstream spans. + From 23891603c6f7fa411df626b95e5e00963da895f9 Mon Sep 17 00:00:00 2001 From: Saman Mahdanian Date: Tue, 26 Mar 2024 12:16:44 +0330 Subject: [PATCH 3/3] added SpawnUpstreamSpan attribute to expected test results Signed-off-by: Saman Mahdanian --- internal/envoy/v3/tracing_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/internal/envoy/v3/tracing_test.go b/internal/envoy/v3/tracing_test.go index 0c4bea5f936..e02ed7d114f 100644 --- a/internal/envoy/v3/tracing_test.go +++ b/internal/envoy/v3/tracing_test.go @@ -111,6 +111,7 @@ func TestTracingConfig(t *testing.T) { }), }, }, + SpawnUpstreamSpan: wrapperspb.Bool(true), }, }, "no custom tag": { @@ -146,6 +147,7 @@ func TestTracingConfig(t *testing.T) { }), }, }, + SpawnUpstreamSpan: wrapperspb.Bool(true), }, }, "no SNI set": { @@ -181,6 +183,7 @@ func TestTracingConfig(t *testing.T) { }), }, }, + SpawnUpstreamSpan: wrapperspb.Bool(true), }, }, }