run workflow subtemplates with new ScanContext #5031
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When executing a workflow, the same ScanContext was used for all the Executers, and since the subtemplates in a workflow run in parallel, the OnResult callback for one template could be overwritten with another template's callback.
Running the subtemplates with a new ScanContext (keeping the same input, i.e.: targets, cookies, args) solves this problem.
fix #4933
Checklist