Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic err using flow templates with workflow #5064

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented Apr 17, 2024

Proposed changes

Closes:

Test:

$ ./nuclei -w workflow-test.yaml -u example.com

workflow-test.yaml same as from #4736 issue.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

pkg/tmplexec/exec.go Outdated Show resolved Hide resolved
@ehsandeep ehsandeep requested a review from tarunKoyalwar April 18, 2024 09:31
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation lgtm !

  • the failing unit test seems to be working locally but errors in gh actions
  • i have updated the test to only run if pdcp keys are available ( if this persists we can create a followup ticket and fix it )

@ehsandeep ehsandeep merged commit 66da73c into dev Apr 18, 2024
9 of 12 checks passed
@ehsandeep ehsandeep deleted the issue-5024-workflow-panic branch April 18, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants