-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support custom config dir #341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation: lgtm
suggesting a minor aesthetic change to remove panic from internals on sporadic config file read error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting this error (test
folder doesn't exist):
$ go run . -config test
...
[INF] Current proxify version 0.0.11 (latest)
[FTL] failed to load open test/cakey.pem while saving private key got open test/cakey.pem: no such file or directory
exit status 1
I think we need O_CREATE|O_TRUNC
also in
Line 61 in 5d6cda1
kf, err := os.OpenFile(keyFile, os.O_WRONLY, 0600) |
os.Create(...)
@Mzack9999 Fixed in #340 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to overwrite config dir, we should use a dedicated and separate option like in nuclei as this conflicts with -config
option, which is generally used to specify the custom tool config file across all the tools.
we can make changes to make sure these cases are covered.
./proxify -config test/custom_config.yaml
./proxify -config-directory custom_dir_to_store_config_files
-cdir, -config-directory string directory to store/read proxify cert/config files ($HOME/.config/proxify)
Proposed changes
This PR fixes custom config dir support -same functionality as
nuclei
. Closes #323 .Checklist