Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow out-of-order event registration #183

Open
UkoeHB opened this issue Jan 19, 2024 · 3 comments
Open

Allow out-of-order event registration #183

UkoeHB opened this issue Jan 19, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@UkoeHB
Copy link
Collaborator

UkoeHB commented Jan 19, 2024

We can do this by storing registered events in a sorted list of typeids, then assigning channel ids based on index.
@Shatur
Copy link
Contributor

Shatur commented Jan 19, 2024

Agree, but shouldn't use TypeId since it's not stable across binaries. Relevant issue in Bevy.
But it looks like we can just use type names.

@UkoeHB
Copy link
Collaborator Author

UkoeHB commented Jan 19, 2024

It looks like type_name is also not stable.

@Shatur
Copy link
Contributor

Shatur commented Jan 19, 2024

Hm... Yes, I missed it. That just what @cart suggested in bevyengine/bevy#32 (comment).
Then I'm not sure how to solve it properly.

@Shatur Shatur added the enhancement New feature or request label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Shatur @UkoeHB