[alertmanager] Fixing "cannot overwrite table with non table" warning #3245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com>
monotek
requested changes
Apr 17, 2023
charts/alertmanager/values.yaml
Outdated
| @@ -41,7 +41,7 @@ priorityClassName: "" | |||
|
|
|||
| podSecurityContext: | |||
| fsGroup: 65534 | |||
| dnsConfig: {} | |||
| dnsConfig: [] | |||
There was a problem hiding this comment.
this does not look like a lst, as the first comment starts with: "# nameservers:"
There was a problem hiding this comment.
Yeah, not sure why I did this. Sorry, hostAliases is the only impacted section. I'll amend.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>
Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>
QuentinBisson
previously approved these changes
May 23, 2023
|
@monotek do you mind merging? |
Signed-off-by: Quentin Bisson <quentin@giantswarm.io>
Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com>
QuentinBisson
approved these changes
May 23, 2023
monotek
approved these changes
May 25, 2023
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
May 31, 2023
…prometheus-community#3245) * Fixing "cannot overwrite table with non table" warning Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> * Correct type at dnsConfig Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Update Chart.yaml Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com> --------- Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> Signed-off-by: Quentin Bisson <quentin@giantswarm.io> Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com> Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com> Co-authored-by: Quentin Bisson <quentin@giantswarm.io> Co-authored-by: Quentin Bisson <quentin.bisson@gmail.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com>
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
Aug 24, 2023
…prometheus-community#3245) * Fixing "cannot overwrite table with non table" warning Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> * Correct type at dnsConfig Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Update Chart.yaml Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com> --------- Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> Signed-off-by: Quentin Bisson <quentin@giantswarm.io> Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com> Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com> Co-authored-by: Quentin Bisson <quentin@giantswarm.io> Co-authored-by: Quentin Bisson <quentin.bisson@gmail.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com>
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
Aug 25, 2023
…prometheus-community#3245) * Fixing "cannot overwrite table with non table" warning Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> * Correct type at dnsConfig Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Update Chart.yaml Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com> --------- Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> Signed-off-by: Quentin Bisson <quentin@giantswarm.io> Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com> Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com> Co-authored-by: Quentin Bisson <quentin@giantswarm.io> Co-authored-by: Quentin Bisson <quentin.bisson@gmail.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com>
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
Aug 25, 2023
…prometheus-community#3245) * Fixing "cannot overwrite table with non table" warning Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> * Correct type at dnsConfig Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Update Chart.yaml Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com> --------- Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> Signed-off-by: Quentin Bisson <quentin@giantswarm.io> Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com> Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com> Co-authored-by: Quentin Bisson <quentin@giantswarm.io> Co-authored-by: Quentin Bisson <quentin.bisson@gmail.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com>
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
Mar 20, 2024
…prometheus-community#3245) * Fixing "cannot overwrite table with non table" warning Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> * Correct type at dnsConfig Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Update Chart.yaml Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com> --------- Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> Signed-off-by: Quentin Bisson <quentin@giantswarm.io> Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com> Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com> Co-authored-by: Quentin Bisson <quentin@giantswarm.io> Co-authored-by: Quentin Bisson <quentin.bisson@gmail.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com>
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
Mar 20, 2024
…prometheus-community#3245) * Fixing "cannot overwrite table with non table" warning Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> * Correct type at dnsConfig Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Update Chart.yaml Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com> --------- Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> Signed-off-by: Quentin Bisson <quentin@giantswarm.io> Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com> Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com> Co-authored-by: Quentin Bisson <quentin@giantswarm.io> Co-authored-by: Quentin Bisson <quentin.bisson@gmail.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com>
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
Mar 20, 2024
…prometheus-community#3245) * Fixing "cannot overwrite table with non table" warning Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> * Correct type at dnsConfig Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Update Chart.yaml Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com> --------- Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> Signed-off-by: Quentin Bisson <quentin@giantswarm.io> Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com> Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com> Co-authored-by: Quentin Bisson <quentin@giantswarm.io> Co-authored-by: Quentin Bisson <quentin.bisson@gmail.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com>
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
Mar 20, 2024
…prometheus-community#3245) * Fixing "cannot overwrite table with non table" warning Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> * Correct type at dnsConfig Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Update Chart.yaml Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com> --------- Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> Signed-off-by: Quentin Bisson <quentin@giantswarm.io> Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com> Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com> Co-authored-by: Quentin Bisson <quentin@giantswarm.io> Co-authored-by: Quentin Bisson <quentin.bisson@gmail.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
When overriding either of the fields
hostAliases:ordnsConfig:we get the following warning:This is due to the
{}type being used as null, whereas we should be using[]. It's possible we have more instances of this in the chart.It's a non-issue but a bit frustrating to encounter.
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])