Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yaml parser panics on bad input #51

Closed
slrtbtfs opened this issue Nov 6, 2019 · 1 comment
Closed

Yaml parser panics on bad input #51

slrtbtfs opened this issue Nov 6, 2019 · 1 comment
Labels
bug Something isn't working crash (potential) crash of the language server security Security related issues upstream Bugs that have to be fixed in a dependency

Comments

@slrtbtfs
Copy link
Member

slrtbtfs commented Nov 6, 2019

go-yaml/yaml#538
@slrtbtfs slrtbtfs added bug Something isn't working security Security related issues crash (potential) crash of the language server upstream Bugs that have to be fixed in a dependency labels Nov 6, 2019
@slrtbtfs
Copy link
Member Author

slrtbtfs commented Nov 6, 2019

Looked at the upstream issue again. Only marshalling seems to be affected. The decoded AST in the given example looks fine.

Currently the PromQL server is only decoding yaml, so it should not be affected by this bug.

@slrtbtfs slrtbtfs closed this as completed Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working crash (potential) crash of the language server security Security related issues upstream Bugs that have to be fixed in a dependency
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slrtbtfs