From e91b4d7e1aaf41e2fa8663b1c134ae886d2bb7ab Mon Sep 17 00:00:00 2001 From: bwplotka Date: Fri, 5 Aug 2022 17:33:24 +0200 Subject: [PATCH] Remove bucket option for now. Signed-off-by: bwplotka --- prometheus/collectors/go_collector_latest.go | 1 + prometheus/internal/go_collector_options.go | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/prometheus/collectors/go_collector_latest.go b/prometheus/collectors/go_collector_latest.go index 10756e030..232601002 100644 --- a/prometheus/collectors/go_collector_latest.go +++ b/prometheus/collectors/go_collector_latest.go @@ -70,6 +70,7 @@ func WithGoCollectorMemStatsMetricsDisabled() func(options *internal.GoCollector } // GoRuntimeMetricsRule allow enabling and configuring particular group of runtime/metrics. +// TODO(bwplotka): Consider adding ability to adjust buckets. type GoRuntimeMetricsRule struct { // Matcher represents RE2 expression will match the runtime/metrics from https://golang.bg/src/runtime/metrics/description.go // Use `regexp.MustCompile` or `regexp.Compile` to create this field. diff --git a/prometheus/internal/go_collector_options.go b/prometheus/internal/go_collector_options.go index 8fd32fcb7..723b45d64 100644 --- a/prometheus/internal/go_collector_options.go +++ b/prometheus/internal/go_collector_options.go @@ -18,7 +18,6 @@ import "regexp" type GoCollectorRule struct { Matcher *regexp.Regexp Deny bool - Buckets interface{} } // GoCollectorOptions should not be used be directly by anything, except `collectors` package.