Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate dashboards to new grafonnet library #3147

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

critchtionary
Copy link

Migrated away from deprecated Grafonnet library. This replaces panels using Angular JS which are disabled by default in Grafana 11 and will be unsupported in Grafana 12.

Fixes #3046

Signed-off-by: Tom <12222103+critchtionary@users.noreply.github.com>
Signed-off-by: Tom <12222103+critchtionary@users.noreply.github.com>
Signed-off-by: Tom <12222103+critchtionary@users.noreply.github.com>
Signed-off-by: Tom <12222103+critchtionary@users.noreply.github.com>
Signed-off-by: Tom <12222103+critchtionary@users.noreply.github.com>
Signed-off-by: Tom <12222103+critchtionary@users.noreply.github.com>
Signed-off-by: Tom <12222103+critchtionary@users.noreply.github.com>
Signed-off-by: Tom <12222103+critchtionary@users.noreply.github.com>
Signed-off-by: Tom <12222103+critchtionary@users.noreply.github.com>
@critchtionary
Copy link
Author

cc @discordianfish @SuperQ

Copy link

@janhorstmann janhorstmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @critchtionary ,
overall LGTM, just something I noticed:
when grafana migrates the original dashboards it adds

"fieldConfig": {  "defaults": { "custom": { "showPoints": "never" }

to the timeSeries panel. Should tsCustom.withShowPoints('never') be added to timeSeries panels?

docs/node-mixin/lib/prom-mixin.libsonnet Outdated Show resolved Hide resolved
docs/node-mixin/lib/prom-mixin.libsonnet Outdated Show resolved Hide resolved
Signed-off-by: Tom <12222103+critchtionary@users.noreply.github.com>
Signed-off-by: Tom <12222103+critchtionary@users.noreply.github.com>
@critchtionary
Copy link
Author

Hey @critchtionary , overall LGTM, just something I noticed: when grafana migrates the original dashboards it adds

"fieldConfig": {  "defaults": { "custom": { "showPoints": "never" }

to the timeSeries panel. Should tsCustom.withShowPoints('never') be added to timeSeries panels?

Auto seemed to be not showing them, but have changed to never.

@jemag
Copy link

jemag commented Dec 3, 2024

Is there any blocker remaining on this?
Otherwise, would be great to have a review. Perhaps @SuperQ or @discordianfish ?

janhorstmann added a commit to osism/kolla-operations that referenced this pull request Dec 7, 2024
As reviewing/merging the pull requests to update the dashboards for the
node-exporter and prometheus mixins takes a long time ([1]), we use the
mixins from the pull requests directly. This may be reverted once the
pull requests are merged.

[1]
prometheus/node_exporter#3147
prometheus/prometheus#15334

Signed-off-by: Jan Horstmann <horstmann@osism.tech>
janhorstmann added a commit to osism/kolla-operations that referenced this pull request Dec 7, 2024
As reviewing/merging the pull requests to update the dashboards for the
node-exporter and prometheus mixins takes a long time ([1]), we use the
mixins from the pull requests directly. This may be reverted once the
pull requests are merged.

[1]
prometheus/node_exporter#3147
prometheus/prometheus#15334

Signed-off-by: Jan Horstmann <horstmann@osism.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grafana angular deprecation in grafana 11
3 participants