Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch logging to go-kit #270

Closed
matthiasr opened this issue Oct 4, 2019 · 2 comments · Fixed by #272
Closed

Switch logging to go-kit #270

matthiasr opened this issue Oct 4, 2019 · 2 comments · Fixed by #272
Assignees
@mhartenbower
Labels
enhancement good first issue help wanted PRs for this issue are especially welcome

Comments

@matthiasr
Copy link
Contributor

About two years ago we decided to move from logrus to go-kit for logging, this is one of the repos that still needs switching. prometheus/snmp_exporter#447 is an example PR.
@matthiasr matthiasr added enhancement good first issue help wanted PRs for this issue are especially welcome labels Oct 4, 2019
@mhartenbower
Copy link
Contributor

@matthiasr I'll help out with this one

@matthiasr
Copy link
Contributor Author

👍 go for it!

mhartenbower added a commit to mhartenbower/statsd_exporter that referenced this issue Oct 10, 2019
@mhartenbower
Switch to go-kit logging
7f1351c 
Fixes prometheus#270
@mhartenbower mhartenbower mentioned this issue Oct 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhartenbower mhartenbower

Labels
enhancement good first issue help wanted PRs for this issue are especially welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to go-kit logging mhartenbower/statsd_exporter
2 participants
@matthiasr @mhartenbower