Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for dropping unmapped metrics #77

Closed
drawks opened this issue Aug 1, 2017 · 2 comments
Closed

Allow for dropping unmapped metrics #77

drawks opened this issue Aug 1, 2017 · 2 comments
Labels
enhancement

Comments

@drawks
Copy link
Contributor

drawks commented Aug 1, 2017

The default behavior of passing unmapped metrics through can result in really polluted metric namespaces when using software that generates a large number of dynamic metrics OR a large number of metrics that are irrelevent to the user's interest. I'd like to be able to switch the behavior in the config to blackholing unmapped metrics.
drawks pushed a commit to drawks/statsd_exporter that referenced this issue Aug 1, 2017
Resolves prometheus#77 add cmdline flag to drop unmapped
78c1369 
* Adds `-statsd.drop-unmapped` cmdline flag which causes statsd metrics
  that don't match a mapping to be dropped. New flag defaults to "false"
drawks pushed a commit to drawks/statsd_exporter that referenced this issue Aug 14, 2017
Resolves prometheus#77 add cmdline flag to drop unmapped
367d5f5 
* Adds `-statsd.drop-unmapped` cmdline flag which causes statsd metrics
  that don't match a mapping to be dropped. New flag defaults to "false"
drawks pushed a commit to drawks/statsd_exporter that referenced this issue Aug 14, 2017
Resolves prometheus#77 add cmdline flag to drop unmapped
59bdece 
* Adds `-statsd.drop-unmapped` cmdline flag which causes statsd metrics
  that don't match a mapping to be dropped. New flag defaults to "false"
@robfig
Copy link

robfig commented Sep 28, 2017 •
edited
Loading

FWIW, I'm looking to start up a prometheus installation, and being unable to repeat some but not all from our existing ~100k graphite metrics is sort of a dealbreaker. Thanks for providing this functionality, I'll be using it! (And I'm happy to see it's on its way to being merged)

This was referenced Sep 28, 2017
Merged
Merged
robfig pushed a commit to yext/statsd_exporter that referenced this issue Oct 4, 2017
@robfig
Resolves prometheus#77 add cmdline flag to drop unmapped
66776a4 
* Adds `-statsd.drop-unmapped` cmdline flag which causes statsd metrics
  that don't match a mapping to be dropped. New flag defaults to "false"

Add test for dropUnmapped behavior

Convert dropUnmapped to a attribute of the Exporter

  * Removed references to dropUnmapped global var in favor of a boolean
    attribute of `Exporter`
  * Updated tests to reflect refactor
  * Reordered command line options per PR review
@matthiasr
Copy link
Contributor

This is fixed by #115. Drop away! Please test from trunk if you're interested in this feature, if there are no issues with it I'm happy to make a release that has it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@matthiasr @drawks @robfig @SuperQ