Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register eventsUnmapped counter #161

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Register eventsUnmapped counter #161

merged 1 commit into from
Nov 5, 2018

Conversation

filippog
Copy link
Contributor

@filippog filippog commented Nov 2, 2018

See also the related discussion at #160

matthiasr
matthiasr approved these changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@matthiasr matthiasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you please add the sign-off?

@filippog
Register eventsUnmapped counter
9b44d79 
See also the related discussion at #160

Signed-off-by: Filippo Giunchedi <filippo@wikimedia.org>
@filippog
Copy link
Contributor Author

filippog commented Nov 3, 2018

For sure! Done

@matthiasr matthiasr merged commit a51c9be into prometheus:master Nov 5, 2018
matthiasr pushed a commit that referenced this pull request Nov 5, 2018
Add changelog entry for #161
397fd90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasr matthiasr matthiasr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filippog @matthiasr