Scale summaries from milliseconds to seconds. #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I rely on CI a lot 😄 let me know when you're ready for a review! |
Fixes prometheus#177 Updating exporter tests for new summary unit scaling behavior Signed-off-by: Spencer Malone <malone.spencer@gmail.com>
|
@matthiasr - This should actually be good to go now, sorry about that! |
|
Thanks a lot! |
matthiasr
pushed a commit
that referenced
this pull request
Jan 9, 2019
No 0.9.0 release candidate was ever published because of CI issues, so we can still add this change before the release. Signed-off-by: Matthias Rampke <mr@soundcloud.com>
wmfgerrit
pushed a commit
to wikimedia/operations-puppet
that referenced
this pull request
May 8, 2019
statsd-exporter 0.9 fixes summaries to scale from milliseconds to seconds, which is what prometheus expects prometheus/statsd_exporter#178 Bug: T220709 Change-Id: I9214bbf764dd99e0cb60c6bcd92d4de442a802a5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #177
EDIT: Oh bleh, I'll actually pull and build and ensure this works, and not rely on CI