Reduce memory allocations in handlePacket #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This converts the byte buffer to a string by casting and parses the string by looping over it instead of calling Split. This usage of unsafe is taken from the strings.Builder package here: https://github.com/golang/go/blob/cb5c82bc3df2e95c2ab36555fefb7cd3f334c685/src/strings/builder.go#L47 Signed-off-by: Clayton O'Neill <claytono@github.com>
|
Sweet, thank you! |
matthiasr
pushed a commit
that referenced
this pull request
May 17, 2019
Signed-off-by: Matthias Rampke <mr@soundcloud.com>
This was referenced May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the byte buffer to a string by casting and parses the
string by looping over it instead of calling Split.
This usage of unsafe is taken from the strings.Builder package here:
https://github.com/golang/go/blob/cb5c82bc3df2e95c2ab36555fefb7cd3f334c685/src/strings/builder.go#L47
This also adds a benchmark for testing overall performance of the UDP code path.
Signed-off-by: Clayton O'Neill claytono@github.com